feat(grouping): Add clearer component ignoring test inputs #105843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f12942 to
3c08b5a
Compare
roggenkemper
approved these changes
Jan 7, 2026
lobsterkatie
added a commit
that referenced
this pull request
Jan 7, 2026
This is a follow-up to #105843, which aimed to replace some confusing grouping test inputs with clearer ones. When that PR included both adding the new inputs and removing the old ones, GitHub erroneously detected file renames rather than replacements. That PR was therefore restricted to the file addition half of the process, with the file removal half included here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our grouping algorithm, one of our checks for whether or not to use a given stacktrace is implemented backwards: We claim to ignore a frame if its
abs_pathisn't a URL, but then only actually do that if itsabs_pathis in fact a URL.This will be fixed in the upcoming new grouping config, but in the process of making that change, it became clear that some of our relevant tests are quite hard to reason about. Specifically, we have two grouping snapshot inputs called
frame_ignores_module_if_page_urlandframe_ignores_module_if_page_url-2, which have a few problems:frame_ignores_module_if_page_urldoesn't illustrate what it says it does at all, in that the module isn't in fact ignored. What it does turn out to illustrate is the URL/non-URL frame ignoring bug discussed above.frame_ignores_module_if_page_url-2does illustrate the module ignoring, but a) its title isn't as clear as it might be, b) it includes a function component, which muddies the waters in terms of what's ignored or not, and c) though it doesn't currently illustrate the URL/non-URL frame ignoring behavior which was previously discussed, once the bug is fixed it will, which will be another thing adding mud to the aforementioned proverbial water.To fix these problems, this PR adds three new inputs: one to illustrate the module ignoring (and only the module ignoring), and one each to illustrate the URL and non-URL frame ignoring cases, respectively. This should make it easier to see the effects of the bug fix, as only the latter two inputs should be affected.
(A follow-up PR will remove the bad inputs. Doing both in a single PR was confusing GitHub, making it think that things had been renamed and slightly modified rather than replaced.)