feat(grouping): Add test input where all exceptions are groups #105666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nora-shap
approved these changes
Jan 5, 2026
cathteng
pushed a commit
that referenced
this pull request
Jan 5, 2026
This adds a new grouping input to our tests, illustrating the case in which all exceptions in a chain are marked as exception groups. Though this shouldn't happen, it does, and we don't handle it gracefully. A fix will be included in an upcoming PR; the input is added here separately so the effects of that fix will be clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new grouping input to our tests, illustrating the case in which all exceptions in a chain are marked as exception groups. Though this shouldn't happen, it does, and we don't handle it gracefully. A fix will be included in an upcoming PR; the input is added here separately so the effects of that fix will be clearer.