feat(occurrences on eap): Implement EAP read for retrieving top issues by event count #105460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashjar
commented
Dec 26, 2025
thetruecpaul
approved these changes
Dec 30, 2025
| ) -> list[dict[str, Any]]: | ||
| """EAP implementation: Given a list of issue group ids, return a sublist of the top 5 ordered by event count""" | ||
| organization = Organization.objects.get(id=project.organization_id) | ||
| now = datetime.now(tz=timezone.utc) |
Contributor
There was a problem hiding this comment.
Note: This appears to technically be different from the Snuba implementation, which doesn't specify a timezone. (Though that might get set somewhere in the Snuba framework?)
| end=now, | ||
| organization=organization, | ||
| projects=[project], | ||
| environments=[], |
Contributor
There was a problem hiding this comment.
Nit: I think environments is an empty list by default
| "integrations.pr_comment.get_top_5_issues_by_count" | ||
| ): | ||
| eap_results = self._get_top_5_issues_by_count_eap(issue_ids, project) | ||
| results = EAPOccurrencesComparator.check_and_choose( |
Contributor
There was a problem hiding this comment.
Nit: Can you add resonable-match and null-result here?
Member
Author
There was a problem hiding this comment.
I'm not sure that reasonable-match makes complete sense here, since the difference in retention could mean that there's no overlap in the highest-count group IDs (although I'm not sure whether this would be common or not)
cathteng
pushed a commit
that referenced
this pull request
Jan 5, 2026
…s by event count (#105460) This PR implements a double read from EAP of the top 5 issues by event count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a double read from EAP of the top 5 issues by event count.