refactor(preprod): update build details to use "Build Metadata" instead of "Git details" and add base build row logic (EME-679) #105244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarContent.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
This might win the award for longest branch name 🤣 |
253d89c to
604bc8b
Compare
604bc8b to
fca93b5
Compare
trevor-e
approved these changes
Dec 18, 2025
Member
trevor-e
left a comment
There was a problem hiding this comment.
Pre-stamped with a suggestion
| version: string | number | null | undefined, | ||
| buildNumber: string | number | null | undefined | ||
| ): string { | ||
| return `v${version ?? 'Unknown'} (${buildNumber ?? 'Unknown'})`; |
Member
There was a problem hiding this comment.
I think we want to move away from showing "Unknown" when the build is still processing, I recommend returning null here so we simply don't display anything. Alternatively we could show some kind of loading state for the base build but I think that's overkill since this is a rare case.
Basically we have a very slight race condition with build processing where the base build could process longer/after the the head build.
…ad of "Git details" and add base build row logic (EME-679) This commit changes the label from "Git details" to "Build Metadata" in the build details sidebar and updates the corresponding tests. Additionally, it introduces logic to render a "Base Build" row based on the presence of `base_sha` and `base_build_info`, enhancing the build details display. New utility functions for formatting build names and generating base build URLs have also been added.
fca93b5 to
fc98b33
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces new functionality to render a "Base Build" row based on the presence of base build information, enhancing the clarity and usability of the build details display. New utility functions for formatting build names and generating base build URLs have also been added. Additionally replaced the title "Git details" with "Build Metadata" in the build details sidebar and related tests.
No Base Build
No Base Artefact
With Base Artefact
Testing
Manual tested and updated and also added integration tests for all three states.
Merging
Requires #105145 to be merged first then this branch will be rebased onto
masterwhich will remove the API changes shown in this PR. For review please just review the frontend changes, backend changes should be reviewed as part of the above linked PR.