feat(aci): add disabled alert to error/metric monitors and alerts #104756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104756 +/- ##
========================================
Coverage 80.48% 80.48%
========================================
Files 9359 9359
Lines 401725 401725
Branches 25822 25822
========================================
Hits 323321 323321
Misses 77962 77962
Partials 442 442 |
malwilley
approved these changes
Dec 11, 2025
| disabled={isEnabling || !canEdit} | ||
| aria-label={t('Enable')} | ||
| title={ | ||
| canEdit ? undefined : t('You do not have permission to enable this alert') |
Member
There was a problem hiding this comment.
Might be nice to do what we do for monitors and link to settings in this case
Contributor
Author
There was a problem hiding this comment.
I just tried this and realized that the Button title is not hoverable 🤔 so I'm going to update all of these to use the Tooltip component with isHoverable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses reusable DisabledAlert component from #103165 to show an alert for disabled metric and error monitors, and adds a matching component for alerts