feat(detectors): Add disabled alert to uptime and cron detector details #103165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a reusable DisabledAlert component that displays a muted alert when a detector is disabled, with a one-click enable button. The alert automatically hides when the detector becomes enabled. Uptime detectors show: "This monitor is disabled and not recording uptime checks." Cron detectors show: "This monitor is disabled and not accepting check-ins." Fixes [NEW-565: Disabled monitors should show a indicator that disabling means not accepting check-ins](https://linear.app/getsentry/issue/NEW-565/disabled-monitors-should-show-a-indicator-that-disabling-means-not) Fixes [NEW-616: Indicate that the monitor is disabled](https://linear.app/getsentry/issue/NEW-616/indicate-that-the-monitor-is-disabled)
|
|
||
| const handleEnable = () => { | ||
| updateDetector({detectorId: detector.id, enabled: true}); | ||
| }; |
Contributor
There was a problem hiding this comment.
Bug: Unauthorized users see alert enable button.
The DisabledAlert component doesn't check user permissions before showing the enable button. The existing DisableDetectorAction uses useCanEditDetector to verify permissions, but DisabledAlert always displays the button when the detector is disabled, allowing users without alerts:write permission to attempt enabling detectors (which will fail at the API level, creating a confusing user experience).
Member
Author
There was a problem hiding this comment.
Looks reasonable, will add
malwilley
approved these changes
Nov 11, 2025
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
…ls (#103165) Adds a reusable DisabledAlert component that displays a muted alert when a detector is disabled, with a one-click enable button. The alert automatically hides when the detector becomes enabled. Uptime detectors show: "This monitor is disabled and not recording uptime checks." Cron detectors show: "This monitor is disabled and not accepting check-ins." Fixes [NEW-565: Disabled monitors should show a indicator that disabling means not accepting check-ins](https://linear.app/getsentry/issue/NEW-565/disabled-monitors-should-show-a-indicator-that-disabling-means-not) Fixes [NEW-616: Indicate that the monitor is disabled](https://linear.app/getsentry/issue/NEW-616/indicate-that-the-monitor-is-disabled)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…ls (#103165) Adds a reusable DisabledAlert component that displays a muted alert when a detector is disabled, with a one-click enable button. The alert automatically hides when the detector becomes enabled. Uptime detectors show: "This monitor is disabled and not recording uptime checks." Cron detectors show: "This monitor is disabled and not accepting check-ins." Fixes [NEW-565: Disabled monitors should show a indicator that disabling means not accepting check-ins](https://linear.app/getsentry/issue/NEW-565/disabled-monitors-should-show-a-indicator-that-disabling-means-not) Fixes [NEW-616: Indicate that the monitor is disabled](https://linear.app/getsentry/issue/NEW-616/indicate-that-the-monitor-is-disabled)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reusable DisabledAlert component that displays a muted alert when
a detector is disabled, with a one-click enable button. The alert
automatically hides when the detector becomes enabled.
Uptime detectors show: "This monitor is disabled and not recording uptime checks."
Cron detectors show: "This monitor is disabled and not accepting check-ins."
Fixes NEW-565: Disabled monitors should show a indicator that disabling means not accepting check-ins
Fixes NEW-616: Indicate that the monitor is disabled