feat(cells): make tempest ips control only #104305
Conversation
| # TODO(cells): This endpoint is moving to control | ||
| @all_silo_endpoint | ||
| @control_silo_endpoint | ||
| class UptimeIpsEndpoint(Endpoint): |
There was a problem hiding this comment.
@evanpurkhiser where is this endpoint being used? it doesn't seem to be via our UI. anywhere else we need to update before turning it off on the region API?
There was a problem hiding this comment.
It’s a public endpoint documented in our docs for hosting providers like cloudflare and vercel to use in their system to automatically receive updates as we add more uptime checkers.
They’ll automatically add these ips to their whitelists so you they don’t accidentally mark our check traffic as a DoS.
Does this change change how this API is accessed?
There was a problem hiding this comment.
Yes -- it's accessed via http://sentry.io/api/0/uptime-ips/ only, and not http://us.sentry.io/api/0/uptime-ips/ and http://de.sentry.io/api/0/uptime-ips/
There was a problem hiding this comment.
guessing this needs to change then?
There was a problem hiding this comment.
There was a problem hiding this comment.
Is it going to be possible to keep this around as a 302. I think we're going to need to let high profile users of this endpoint know this is changing
There was a problem hiding this comment.
Yes, what date should i put down for the removal? Couple of months?
There was a problem hiding this comment.
reverted this part for now, we'll wait a "few months"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104305 +/- ##
=========================================
Coverage 80.60% 80.60%
=========================================
Files 9340 9340
Lines 399038 399396 +358
Branches 25560 25560
=========================================
+ Hits 321628 321937 +309
- Misses 76961 77010 +49
Partials 449 449 |
| from sentry.testutils.silo import control_silo_test | ||
|
|
||
|
|
||
| @control_silo_test |
There was a problem hiding this comment.
Bug: Uptime endpoint not changed to control silo
The test for UptimeIpsEndpoint was updated to use @control_silo_test, but the actual endpoint in src/sentry/uptime/endpoints/uptime_ips.py still uses @all_silo_endpoint and retains the TODO comment about moving to control. Based on the PR title "make tempest and uptime ips control only", the uptime endpoint implementation appears to have been accidentally omitted from this change, causing a mismatch between the test and implementation.
There was a problem hiding this comment.
leaving this as-is. the endpoint will eventually be control-only
No description provided.