-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(aci): Add an open in explore button to metric detector charts #104301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de24e05 to
e1f7846
Compare
static/app/views/detectors/components/details/metric/getDetectorOpenInDestination.tsx
Show resolved
Hide resolved
scttcper
reviewed
Dec 3, 2025
Comment on lines
+74
to
+77
| dataset: | ||
| snubaQuery.dataset === Dataset.ERRORS | ||
| ? DiscoverDatasets.ERRORS | ||
| : DiscoverDatasets.TRANSACTIONS, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would need to be traces on the spans page
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated - discover link is replaced by a link to traces with is_transaction:true appended to the query
static/app/views/detectors/components/details/metric/getDetectorOpenInDestination.tsx
Show resolved
Hide resolved
scttcper
approved these changes
Dec 5, 2025
ryan953
pushed a commit
that referenced
this pull request
Dec 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works similarly to the one in metric alerts. Gives the user an easy way to delve deeper into what's going on.