feat(autofix): Add email-based user mapping for Seer Autofix PR review requests #103406

JoshFerge · 2025-11-14T21:59:10Z

Summary

Implements email-based user mapping for Seer Autofix PRs to automatically request review from the triggering user, making it easier for users to track their Autofix PRs.

Fixes AIML-1597

Problem

Users lose track of Seer-authored Autofix PRs because Seer is the PR author. When users trigger Autofix, they easily lose track of the resulting PR since it's not assigned or associated with them in GitHub.

Solution

This PR enhances GitHub username resolution to check multiple sources, similar to how suspect commits maps users via email:

Changes

Created shared helper function (get_github_username_for_user() in src/sentry/utils/committers.py)
- Checks ExternalActor for direct user→GitHub mappings (existing behavior)
- Falls back to CommitAuthor email matching (like suspect commits does)
- Extracts GitHub username from CommitAuthor.external_id format: github:username or github_enterprise:username
- Returns GitHub username or None
Updated autofix (src/sentry/seer/autofix/autofix.py)
- Refactored _get_github_username_for_user() to use shared helper
- Removed duplicate code and unused imports
Added comprehensive tests (tests/sentry/seer/autofix/test_autofix.py)
- 6 new test cases for CommitAuthor fallback scenarios
- Tests ExternalActor priority, GitHub Enterprise support, org scoping
- All 48 related tests pass (11 new + 37 existing)

How It Works

When a user triggers Autofix:

Sentry resolves their GitHub username using the new shared helper
Helper checks ExternalActor first (fastest, most reliable)
If not found, falls back to CommitAuthor by matching user's verified emails
If matching CommitAuthor has GitHub external_id, extracts username
Sentry passes GitHub username to Seer in the autofix request
Seer creates PR and automatically requests review from that GitHub user

Expected Impact

Users who don't have an ExternalActor mapping but have committed code with their email to GitHub repos will now have Autofix PRs automatically request their review, making PRs easier to find and track.

Test Plan

All new tests pass (11 GitHub username tests)
All existing tests pass (37 suspect commits tests, no regressions)
Pre-commit hooks pass (black, isort, flake8, mypy)
Manual testing: Trigger Autofix and verify PR review request

Files Changed

src/sentry/utils/committers.py - Added shared helper function
src/sentry/seer/autofix/autofix.py - Updated to use shared helper
tests/sentry/seer/autofix/test_autofix.py - Added 6 new test cases

Users lose track of Seer-authored Autofix PRs because Seer is the PR author. This change enables automatic PR review requests to the triggering user by resolving their GitHub username from multiple sources. Changes: - Add shared `get_github_username_for_user()` helper in committers.py - Check ExternalActor for direct user→GitHub mappings (existing behavior) - Fall back to CommitAuthor email matching (like suspect commits) - Extract GitHub username from CommitAuthor.external_id - Add structured logging to track mapping sources - Update autofix to use shared helper instead of duplicate code - Add 6 new test cases for CommitAuthor fallback scenarios When users trigger Autofix, if their email matches a CommitAuthor with a GitHub external_id, Seer will automatically request their review on the PR, making it easier to track and find their Autofix PRs. Fixes AIML-1597

linear · 2025-11-14T21:59:13Z

AIML-1597 Investigate email-based user mapping for Seer Autofix PRs

semgrep-code-getsentry · 2025-11-14T22:03:19Z

src/sentry/utils/committers.py

+            CommitAuthor.objects.filter(
+                organization_id=organization_id,
+                email__in=[email.lower() for email in user_emails],
+                external_id__isnull=False,
+            )
+            .exclude(external_id="")


Risk: Affected versions of django are vulnerable to Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'). The ORM methods QuerySet.filter(), QuerySet.exclude(), QuerySet.get() and the Q() class can be tricked into SQL injection when you pass a specially crafted dictionary via **kwargs that includes a malicious _connector entry. This bypasses the normal query parameterization and lets an attacker inject arbitrary SQL into the WHERE clause.

Fix: Upgrade this library to at least version 5.2.8 at sentry/uv.lock:305.

Reference(s): GHSA-frmv-pr5f-9mcr, CVE-2025-64459

⭐ Fixed in commit 91219f4 ⭐

semgrep-code-getsentry · 2025-11-14T22:03:20Z

src/sentry/utils/committers.py

+        ExternalActor.objects.filter(
+            user_id=user.id,
+            organization_id=organization_id,
+            provider__in=[
+                ExternalProviders.GITHUB.value,
+                ExternalProviders.GITHUB_ENTERPRISE.value,
+            ],
+        )


Risk: Affected versions of django are vulnerable to Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'). The ORM methods QuerySet.filter(), QuerySet.exclude(), QuerySet.get() and the Q() class can be tricked into SQL injection when you pass a specially crafted dictionary via **kwargs that includes a malicious _connector entry. This bypasses the normal query parameterization and lets an attacker inject arbitrary SQL into the WHERE clause.

Fix: Upgrade this library to at least version 5.2.8 at sentry/uv.lock:305.

Reference(s): GHSA-frmv-pr5f-9mcr, CVE-2025-64459

🎉 Removed in commit d3ede3f 🎉

semgrep-code-getsentry · 2025-11-14T22:03:21Z

Semgrep found 1 ssc-e23b0a49-86b3-48bc-b82c-03656ca7eaee finding:

src/sentry/utils/committers.py
- L514-519 - Triage

Risk: Affected versions of django are vulnerable to Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'). The ORM methods QuerySet.filter(), QuerySet.exclude(), QuerySet.get() and the Q() class can be tricked into SQL injection when you pass a specially crafted dictionary via **kwargs that includes a malicious _connector entry. This bypasses the normal query parameterization and lets an attacker inject arbitrary SQL into the WHERE clause.

Fix: Upgrade this library to at least version 5.2.8 at sentry/uv.lock:305.

Reference(s): GHSA-frmv-pr5f-9mcr, CVE-2025-64459

- Move all imports from inside get_github_username_for_user() to module level - Remove all logging statements from the helper function

semgrep-code-getsentry · 2025-11-14T22:09:12Z

src/sentry/utils/committers.py

+            CommitAuthor.objects.filter(
+                organization_id=organization_id,
+                email__in=[email.lower() for email in user_emails],
+                external_id__isnull=False,
+            )
+            .exclude(external_id="")


Risk: Affected versions of django are vulnerable to Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'). The ORM methods QuerySet.filter(), QuerySet.exclude(), QuerySet.get() and the Q() class can be tricked into SQL injection when you pass a specially crafted dictionary via **kwargs that includes a malicious _connector entry. This bypasses the normal query parameterization and lets an attacker inject arbitrary SQL into the WHERE clause.

Fix: Upgrade this library to at least version 5.2.8 at sentry/uv.lock:305.

Reference(s): GHSA-frmv-pr5f-9mcr, CVE-2025-64459

🍰 Removed in commit d3ede3f 🍰

semgrep-code-getsentry · 2025-11-14T22:09:13Z

Semgrep found 1 ssc-e23b0a49-86b3-48bc-b82c-03656ca7eaee finding:

src/sentry/utils/committers.py
- L498-503 - Triage

Risk: Affected versions of django are vulnerable to Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'). The ORM methods QuerySet.filter(), QuerySet.exclude(), QuerySet.get() and the Q() class can be tricked into SQL injection when you pass a specially crafted dictionary via **kwargs that includes a malicious _connector entry. This bypasses the normal query parameterization and lets an attacker inject arbitrary SQL into the WHERE clause.

Fix: Upgrade this library to at least version 5.2.8 at sentry/uv.lock:305.

Reference(s): GHSA-frmv-pr5f-9mcr, CVE-2025-64459

- Move implementation from committers.py directly into _get_github_username_for_user in autofix.py - Remove now-unused shared helper function from committers.py - Remove unused imports from committers.py - Keep all logic in autofix where it's actually used

semgrep-code-getsentry · 2025-11-14T22:14:38Z

src/sentry/seer/autofix/autofix.py

+            CommitAuthor.objects.filter(
+                organization_id=organization_id,
+                email__in=[email.lower() for email in user_emails],
+                external_id__isnull=False,
+            )
+            .exclude(external_id="")


Critical severity and reachable issue identified in your code:
Line 394 has a vulnerable usage of django, introducing a critical severity vulnerability.

ℹ️ Why this is reachable

A reachable issue is a real security risk because your project actually executes the vulnerable code. This issue is reachable because your code uses a certain version of django.
Affected versions of django are vulnerable to Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'). The ORM methods QuerySet.filter(), QuerySet.exclude(), QuerySet.get() and the Q() class can be tricked into SQL injection when you pass a specially crafted dictionary via **kwargs that includes a malicious _connector entry. This bypasses the normal query parameterization and lets an attacker inject arbitrary SQL into the WHERE clause.

References: GHSA, CVE

To resolve this comment:
Upgrade this dependency to at least version 5.2.8 at uv.lock.

💬 Ignore this finding

To ignore this, reply with:

/fp <comment> for false positive

/ar <comment> for acceptable risk

/other <comment> for all other reasons

_{You can view more details on this finding in the Semgrep AppSec Platform here.}

semgrep-code-getsentry · 2025-11-14T22:14:39Z

Semgrep found 1 ssc-e23b0a49-86b3-48bc-b82c-03656ca7eaee finding:

src/sentry/seer/autofix/autofix.py
- L394-399 - Triage

Risk: Affected versions of django are vulnerable to Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection'). The ORM methods QuerySet.filter(), QuerySet.exclude(), QuerySet.get() and the Q() class can be tricked into SQL injection when you pass a specially crafted dictionary via **kwargs that includes a malicious _connector entry. This bypasses the normal query parameterization and lets an attacker inject arbitrary SQL into the WHERE clause.

Fix: Upgrade this library to at least version 5.2.8 at sentry/uv.lock:305.

Reference(s): GHSA-frmv-pr5f-9mcr, CVE-2025-64459

codecov · 2025-11-14T22:24:20Z

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/seer/autofix/autofix.py	85.71%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #103406      +/-   ##
===========================================
+ Coverage   78.11%    80.50%   +2.39%     
===========================================
  Files        9352      9352              
  Lines      400391    400407      +16     
  Branches    25700     25700              
===========================================
+ Hits       312778    322364    +9586     
+ Misses      87145     77575    -9570     
  Partials      468       468

…d-user-mapping-for-seer-autofix-prs

getsantry · 2025-12-06T08:01:32Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

…d-user-mapping-for-seer-autofix-prs

shruthilayaj · 2025-12-08T18:28:24Z

I tested this PR locally to the point where I ensure I make the seer call is made with the correct github user when no ExternalActor object is present but a CommitAuthor is present (I set up a github app integration to populate CommitAuthor). It looks good to me.

src/sentry/seer/autofix/autofix.py

JoshFerge

lgtm!

…w requests (#103406) ## Summary Implements email-based user mapping for Seer Autofix PRs to automatically request review from the triggering user, making it easier for users to track their Autofix PRs. Fixes AIML-1597 ## Problem Users lose track of Seer-authored Autofix PRs because Seer is the PR author. When users trigger Autofix, they easily lose track of the resulting PR since it's not assigned or associated with them in GitHub. ## Solution This PR enhances GitHub username resolution to check multiple sources, similar to how suspect commits maps users via email: ### Changes 1. **Created shared helper function** (`get_github_username_for_user()` in `src/sentry/utils/committers.py`) - Checks `ExternalActor` for direct user→GitHub mappings (existing behavior) - Falls back to `CommitAuthor` email matching (like suspect commits does) - Extracts GitHub username from `CommitAuthor.external_id` format: `github:username` or `github_enterprise:username` - Returns GitHub username or None 2. **Updated autofix** (`src/sentry/seer/autofix/autofix.py`) - Refactored `_get_github_username_for_user()` to use shared helper - Removed duplicate code and unused imports 3. **Added comprehensive tests** (`tests/sentry/seer/autofix/test_autofix.py`) - 6 new test cases for CommitAuthor fallback scenarios - Tests ExternalActor priority, GitHub Enterprise support, org scoping - All 48 related tests pass (11 new + 37 existing) ## How It Works When a user triggers Autofix: 1. Sentry resolves their GitHub username using the new shared helper 2. Helper checks `ExternalActor` first (fastest, most reliable) 3. If not found, falls back to `CommitAuthor` by matching user's verified emails 4. If matching `CommitAuthor` has GitHub `external_id`, extracts username 5. Sentry passes GitHub username to Seer in the autofix request 6. Seer creates PR and automatically requests review from that GitHub user ## Expected Impact Users who don't have an `ExternalActor` mapping but have committed code with their email to GitHub repos will now have Autofix PRs automatically request their review, making PRs easier to find and track. ## Test Plan - [x] All new tests pass (11 GitHub username tests) - [x] All existing tests pass (37 suspect commits tests, no regressions) - [x] Pre-commit hooks pass (black, isort, flake8, mypy) - [ ] Manual testing: Trigger Autofix and verify PR review request ## Files Changed - `src/sentry/utils/committers.py` - Added shared helper function - `src/sentry/seer/autofix/autofix.py` - Updated to use shared helper - `tests/sentry/seer/autofix/test_autofix.py` - Added 6 new test cases --------- Co-authored-by: Shruthilaya Jaganathan <shruthilaya.jaganathan@sentry.io>

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 14, 2025

vercel bot deployed to Preview November 14, 2025 22:01 View deployment

semgrep-code-getsentry bot reviewed Nov 14, 2025

View reviewed changes

refactor: Move imports to module level and remove logging

91219f4

- Move all imports from inside get_github_username_for_user() to module level - Remove all logging statements from the helper function

vercel bot deployed to Preview November 14, 2025 22:08 View deployment

semgrep-code-getsentry bot reviewed Nov 14, 2025

View reviewed changes

vercel bot deployed to Preview November 14, 2025 22:14 View deployment

semgrep-code-getsentry bot reviewed Nov 14, 2025

View reviewed changes

shruthilayaj added 2 commits December 4, 2025 11:53

Merge branch 'master' into joshferge/aiml-1597-investigate-email-base…

33cdcc3

…d-user-mapping-for-seer-autofix-prs

Merge branch 'master' into joshferge/aiml-1597-investigate-email-base…

ef6e98b

…d-user-mapping-for-seer-autofix-prs

getsantry bot added the Stale label Dec 6, 2025

shruthilayaj marked this pull request as ready for review December 8, 2025 18:25

shruthilayaj requested a review from a team as a code owner December 8, 2025 18:25

Merge branch 'master' into joshferge/aiml-1597-investigate-email-base…

f372d62

…d-user-mapping-for-seer-autofix-prs

shruthilayaj approved these changes Dec 8, 2025

View reviewed changes

vercel bot deployed to Preview December 8, 2025 18:31 View deployment

cursor bot reviewed Dec 8, 2025

View reviewed changes

src/sentry/seer/autofix/autofix.py Outdated Show resolved Hide resolved

only use verified emails to check for commit author

5ebfb92

vercel bot deployed to Preview December 8, 2025 19:06 View deployment

cursor bot reviewed Dec 8, 2025

View reviewed changes

src/sentry/seer/autofix/autofix.py Outdated Show resolved Hide resolved

else block never executed

503ffd2

vercel bot deployed to Preview December 8, 2025 19:31 View deployment

JoshFerge commented Dec 8, 2025

View reviewed changes

shruthilayaj merged commit abf2622 into master Dec 8, 2025
72 of 74 checks passed

shruthilayaj deleted the joshferge/aiml-1597-investigate-email-based-user-mapping-for-seer-autofix-prs branch December 8, 2025 19:59

github-actions bot locked and limited conversation to collaborators Dec 24, 2025

Uh oh!

feat(autofix): Add email-based user mapping for Seer Autofix PR review requests #103406

feat(autofix): Add email-based user mapping for Seer Autofix PR review requests #103406

Uh oh!

Conversation

JoshFerge commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Changes

How It Works

Expected Impact

Test Plan

Files Changed

Uh oh!

linear bot commented Nov 14, 2025

Uh oh!

semgrep-code-getsentry bot Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

semgrep-code-getsentry bot Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

semgrep-code-getsentry bot commented Nov 14, 2025

Uh oh!

semgrep-code-getsentry bot Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

semgrep-code-getsentry bot commented Nov 14, 2025

Uh oh!

semgrep-code-getsentry bot Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

semgrep-code-getsentry bot commented Nov 14, 2025

Uh oh!

codecov bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

getsantry bot commented Dec 6, 2025

Uh oh!

shruthilayaj commented Dec 8, 2025

Uh oh!

Uh oh!

Uh oh!

JoshFerge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JoshFerge commented Nov 14, 2025 •

edited

Loading

semgrep-code-getsentry bot Nov 14, 2025 •

edited

Loading

semgrep-code-getsentry bot Nov 14, 2025 •

edited

Loading

semgrep-code-getsentry bot Nov 14, 2025 •

edited

Loading

codecov bot commented Nov 14, 2025 •

edited

Loading