feat(preprod): Wireup app icon frontend #102118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
b477bad to
6047256
Compare
c5561d3 to
6835a33
Compare
6047256 to
14a45a0
Compare
14a45a0 to
abc9c7b
Compare
abc9c7b to
f7b9147
Compare
trevor-e
approved these changes
Oct 30, 2025
f7b9147 to
7f5592e
Compare
7f5592e to
d51439e
Compare
35dbef3 to
36eeea1
Compare
d51439e to
ef60d41
Compare
36eeea1 to
4f0e1e9
Compare
7aedd97 to
25db450
Compare
e2a8a0c to
72d0fa5
Compare
ef60d41 to
0fca64b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ryan/add_api_to_serve_preprod_app_icons #102118 +/- ##
============================================================================
- Coverage 80.61% 80.61% -0.01%
============================================================================
Files 9414 9414
Lines 403745 403743 -2
Branches 25662 25662
============================================================================
- Hits 325475 325473 -2
Misses 77801 77801
Partials 469 469 |
bdfdd95 to
394d8fb
Compare
0fca64b to
5736863
Compare
5736863 to
7f83bd2
Compare
rbro112
added a commit
that referenced
this pull request
Dec 17, 2025
Adds a new preprod `/files/images/<image_id>` endpoint which allows our frontend to download images from an ID with objectstore. First to be used with app icons coming soon. Tested fully E2E locally and all works well. To work, this is reliant on landing getsentry/launchpad#430 once we get a published version of the objectstore client, but since nobody will be consuming this endpoint until we land the stacked PR (#102118) this is safe to go ahead and merge. --------- Co-authored-by: Abdullah Khan <60121741+Abdkhan14@users.noreply.github.com> Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
Base automatically changed from
ryan/add_api_to_serve_preprod_app_icons
to
master
December 17, 2025 18:41
7f83bd2 to
d3c3295
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries the new preprod
files/images/API to get the app icon if available. If not available, falls back to a Sentry purple icon with the first character of the app's name.