Skip to content

test: run errors-only integration tests#3910

Merged
aldy505 merged 3 commits intomasterfrom
aldy505/test/errors-only-integration-test
Sep 2, 2025
Merged

test: run errors-only integration tests#3910
aldy505 merged 3 commits intomasterfrom
aldy505/test/errors-only-integration-test

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Aug 29, 2025 •
edited
Loading

Depends on #3911

@aldy505
Copy link
Collaborator Author

aldy505 commented Aug 29, 2025 

  Error response from daemon: No such image: ghcr.io/getsentry/vroom:nightly
  Error in install/ensure-correct-permissions-profiles-dir.sh:11.
  '$dcr --no-deps --entrypoint /bin/bash --user root vroom -c 'chown -R vroom:vroom /var/vroom/sentry-profiles && chmod -R o+rwx /var/vroom/sentry-profiles'' exited with status 1
  yes: standard output: Broken pipe
  yes: standard output: Broken pipe
  -> ./install.sh:main:41
  --> install/ensure-correct-permissions-profiles-dir.sh:source:11

yep this is expected

@codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.45%. Comparing base (de21398) to head (a20f9e5).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3910   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      184    +1     
=======================================
+ Hits          182      183    +1     
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 aldy505 requested review from BYK and aminvakil September 2, 2025 11:47
aminvakil
aminvakil reviewed Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this after #3911 .

@aldy505 aldy505 merged commit af32d37 into master Sep 2, 2025
15 checks passed
@aldy505 aldy505 deleted the aldy505/test/errors-only-integration-test branch September 2, 2025 23:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BYK BYK BYK approved these changes

+1 more reviewer

@aminvakil aminvakil aminvakil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Self-hosted Sentry
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aldy505 @BYK @aminvakil