fix: ensuring vroom permission should be skipped on errors-only#3911
fix: ensuring vroom permission should be skipped on errors-only#3911
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3911 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 3 3
Lines 183 183
=======================================
Hits 182 182
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
I don't know why the arm64 integration test is failing. |
aminvakil
left a comment
There was a problem hiding this comment.
This change affects other files in install as well.
| # Should only run when `$COMPOSE_PROFILES` is set to `feature-complete` | ||
| if [[ "$COMPOSE_PROFILES" == "errors-only" ]]; then | ||
| echo "Skipping permissions check for profiles directory." | ||
| exit 0 |
There was a problem hiding this comment.
| exit 0 | |
| exit 0 |
This prevents the next files sourced in install.sh to be executed, is this fine?
There was a problem hiding this comment.
Should I enclose this within the if clause instead of exiting?
There was a problem hiding this comment.
Yes, do not exit 0 whatever you do :)
|
Alright now, the FOSSA thingy. Burak said this:
|
No description provided.