Merged
Conversation
Swatinem
reviewed
Jul 18, 2023
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
Do we also want
SourceMapIndexto be able to have a debug id?
Probably not I would say.
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub x_facebook_sources: FacebookSources, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub debug_id: Option<DebugId>, |
Contributor
There was a problem hiding this comment.
I see the type is not #[non_exhaustive], but I believe it is not public so this should be fine.
kamilogorek
approved these changes
Jul 19, 2023
Boshen
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Oct 7, 2024
The sourcemap [`debugId` proposal](https://github.com/tc39/source-map/blob/main/proposals/debug-id.md) adds globally unique build or debug IDs to source maps and generated code, making build artifacts self-identifying. Support for debug IDs was added to [`rust-sourcemap`](getsentry/rust-sourcemap#66) in 2023 and Sentry have made use of this to aid in matching up source and sourcemap files without having to worry about path mismatches or release versions. I want to add debug ID support to Rolldown but it uses `oxc::sourcemap` so it looks like I need to start here first!
Boshen
pushed a commit
to oxc-project/oxc-sourcemap
that referenced
this pull request
Dec 3, 2024
The sourcemap [`debugId` proposal](https://github.com/tc39/source-map/blob/main/proposals/debug-id.md) adds globally unique build or debug IDs to source maps and generated code, making build artifacts self-identifying. Support for debug IDs was added to [`rust-sourcemap`](getsentry/rust-sourcemap#66) in 2023 and Sentry have made use of this to aid in matching up source and sourcemap files without having to worry about path mismatches or release versions. I want to add debug ID support to Rolldown but it uses `oxc::sourcemap` so it looks like I need to start here first!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for reading and writing debug ids in sourcemaps.
Question: Do we also want
SourceMapIndexto be able to have a debug id?