ref(repo): Add @sentry-internal namespace to rrweb package names#17
ref(repo): Add @sentry-internal namespace to rrweb package names#17Lms24 merged 1 commit intopublish-forkfrom
@sentry-internal namespace to rrweb package names#17Conversation
| name: config.name, | ||
| format: 'iife', | ||
| file: pkg.unpkg.replace(pkg.name, config.path), | ||
| extend: true, |
There was a problem hiding this comment.
This is the only deliberate change I made: After changing the namespace, rollup threw an error that the package name is illegal unless I add this option. Tbh I'm not entirely sure what the problem here is but I don't think we need this particular build config anyway.
|
Hmm looks like prettier wasn't run on a lot of files... should we discard the autoformat changes? |
@sentry-internal namespace to rrweb package names
|
Looks good to me! IMHO we can merge the prettier stuff as well, otherwise it'll come at a later point. Or, maybe we make one PR first with just the prettier changes, then a second one with the package changes? |
Sounds good to me 👍 |
3ef18f5 to
12ba25b
Compare
billyvg
left a comment
There was a problem hiding this comment.
using the internal namespace makes sense to me, we are not intending for the general public to be using this package.
rename the rrweb packages by prepending our `@sentry-internal` namespace. I opted to take the internal one over the usual @sentry namespace as I find it more fitting for the purpose we want to release these packages for.
This PR renames the rrweb packages by prepending our
@sentry-internalnamespace. I opted to take the internal one over the usual @sentry namespace as I find it more fitting for the purpose we want to release these packages for.Note: I'm opening this PR against a
publish-forkbranch so we can continue adding fixes and patching rrweb manually until these packages are released.ref #15