Skip to content

meta(changelog): Add changelog for 2.0.1#112

Merged
mydea merged 1 commit intosentry-v2from
fn/changelog-2.0.1
Oct 13, 2023
Merged

meta(changelog): Add changelog for 2.0.1#112
mydea merged 1 commit intosentry-v2from
fn/changelog-2.0.1

Conversation

@mydea
Copy link
Member

@mydea mydea commented Oct 13, 2023

Small patch release.

@mydea mydea requested review from Lms24 and lforst October 13, 2023 08:07
@mydea mydea self-assigned this Oct 13, 2023
@mydea mydea merged commit 94ef0f1 into sentry-v2 Oct 13, 2023
@mydea mydea deleted the fn/changelog-2.0.1 branch October 13, 2023 09:01
billyvg pushed a commit that referenced this pull request Oct 20, 2023
billyvg pushed a commit that referenced this pull request Dec 8, 2023
* Fix serialization and mutation of <textarea> elements taking account the duality that the value can be set in either the child node, or in the value _parameter_ (not attribute)

* Backwards compatibility: Bug fix and regression test for #112
 - this is to fix up 'historical' recordings, as duplicate textarea content should no longer be being created at record time
 - new test shows what the snapshot generated by previous versions of rrweb used to look like, hence 'bad'
 - original 0efe23f fix either didn't work or no longer works due to childNodes being appended subsequent to this part of the code
 - during review, we also verified that the `_cssText` case should still be handled okay, as there's currently no scenario where csstext is present with css child nodes of a <style>

* Masking: Fix that textarea values were being missed by the masking system if the value was recorded as a child node
 - I didn't notice that form.html was used in other tests, so lucky that I noticed that those tests also should have the 'pre value' masked out

* Simplify by always storing the textarea value in the `.value` attribute (from it's DOM property) and not as a childNode. It should still be rebuilt as a childNode rather than a property
---------

Authored-by: eoghanmurray <eoghan@getthere.ie>
billyvg pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants