fix: Fix checking for patchTarget in initAdoptedStyleSheetObserver#110
Merged
fix: Fix checking for patchTarget in initAdoptedStyleSheetObserver#110
patchTarget in initAdoptedStyleSheetObserver#110Conversation
3 tasks
billyvg
approved these changes
Oct 12, 2023
Member
Author
|
Opened PR upstream as well: rrweb-io#1327 |
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 13, 2023
Fix checking for patchTarget in initAdoptedStyleSheetObserver [#110](getsentry/rrweb#110) https://github.com/getsentry/rrweb/blob/sentry-v2/CHANGELOG.md#201
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 13, 2023
* Fix checking for patchTarget in initAdoptedStyleSheetObserver [#110](getsentry/rrweb#110) https://github.com/getsentry/rrweb/blob/sentry-v2/CHANGELOG.md#201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Object.getOwnPropertyDescriptor(undefined, 'xx')actually errors out, so let's probably guard there.