updated _form_response function#685
Merged
markstory merged 1 commit intogetsentry:masterfrom Oct 23, 2023
Merged
Conversation
…ing the correct `HTTPResponse` from `http` rather than from `urllib3`
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
3 tasks
beliaev-maksim
added a commit
to beliaev-maksim/responses
that referenced
this pull request
Nov 14, 2023
* Added comment why this is the behaviour we have * Added run on the test to fix coverage
markstory
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Revert socket change (#685) * Added comment why this is the behaviour we have * Added run on the test to fix coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated
_form_responsefunction with more native handling by utilizing the correctHTTPResponsefromhttprather than fromurllib3