Skip to content

feat(docker): Switch to a distroless base image#4940

Merged
Dav1dde merged 3 commits intomasterfrom
dav1d/distroless
Aug 1, 2025
Merged

feat(docker): Switch to a distroless base image#4940
Dav1dde merged 3 commits intomasterfrom
dav1d/distroless

Conversation

@Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Jul 15, 2025 •
edited
Loading

Switches the docker image to a distroless variant.

Closes: #4871

@Dav1dde Dav1dde self-assigned this Jul 15, 2025
@Dav1dde Dav1dde added the Trigger: Full-CI Runs all CI steps in a PR label Jul 15, 2025
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch 2 times, most recently from ee2b199 to 9151566 Compare July 15, 2025 14:02
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch 4 times, most recently from a3534a2 to c7aac11 Compare July 16, 2025 07:53
aldy505
aldy505 reviewed Jul 17, 2025
View reviewed changes
@aldy505
Copy link
Collaborator

aldy505 commented Jul 17, 2025

there you go

relay-1                            | error: 'relay' requires a subcommand but one was not provided
relay-1                            |   [subcommands: run, credentials, config, generate-completions]
relay-1                            | 
relay-1                            | Usage: relay [OPTIONS] <COMMAND>
relay-1                            | 
relay-1                            | For more information, try '--help'.

aldy505
aldy505 reviewed Jul 17, 2025
View reviewed changes
@aldy505 aldy505 mentioned this pull request Jul 18, 2025
Merged
BYK pushed a commit to getsentry/self-hosted that referenced this pull request Jul 19, 2025
@aldy505
feat: inspect docker compose failure on self-hosted e2e action (#3817)
9fbd722 
It's hard to debug docker compose failure on other repositories since they can't see the `docker compose ps` and `docker compose logs`. One problem occurred here: getsentry/relay#4940

This PR aims to provide both commands if failure happens.
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch from 305272b to 8bd1d7f Compare July 23, 2025 12:10
@Dav1dde Dav1dde marked this pull request as ready for review July 25, 2025 13:37
@Dav1dde Dav1dde requested a review from a team as a code owner July 25, 2025 13:37
@Dav1dde Dav1dde force-pushed the dav1d/distroless branch from 8bd1d7f to 7d8ab79 Compare July 25, 2025 13:41
mdtro
mdtro reviewed Jul 25, 2025
View reviewed changes
@Dav1dde Dav1dde added this pull request to the merge queue Aug 1, 2025
Merged via the queue into master with commit 3eadb1c Aug 1, 2025
39 checks passed
@Dav1dde Dav1dde deleted the dav1d/distroless branch August 1, 2025 10:00
@aldy505
Copy link
Collaborator

aldy505 commented Aug 1, 2025

wooooooooo

Dav1dde added a commit that referenced this pull request Aug 1, 2025
@Dav1dde
Revert "feat(docker): Switch to a distroless base image (#4940)"
859f3db 
This reverts commit 3eadb1c.
This reverts commit 8081d0c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loewenheim loewenheim loewenheim approved these changes

+2 more reviewers

@aldy505 aldy505 aldy505 left review comments

@mdtro mdtro mdtro left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Dav1dde Dav1dde

Labels

Trigger: Full-CI Runs all CI steps in a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch to distroless container

4 participants

@Dav1dde @aldy505 @loewenheim @mdtro