feat(ourlogs): Add browser name/version to logs#4757
Merged
AbhiPrasad merged 5 commits intomasterfrom May 28, 2025
Merged
Conversation
fb0651e to
64dfb13
Compare
64dfb13 to
cf1aece
Compare
Dav1dde
reviewed
May 22, 2025
Member
Dav1dde
left a comment
There was a problem hiding this comment.
Mostly nits, would be great if you can also modify an existing integration test.
Contributor
Author
|
Addressed PR review comments, and added a changelog entry.
I pushed up a new integration test in b1aacc3 |
Contributor
Author
|
CI seems to be failing because of the types - but they should be correct (I can build and test locally). I think this is a stale cache issue. Is there an easy way to blow up the cache and reset this? |
Member
|
@AbhiPrasad it's most likely failing because you test locally with |
Contributor
Author
|
Good catch @Dav1dde. Would you prefer if I moved the processing logic into it's own folder (I see this pattern with |
Member
|
I think just moving all processing stuff to a new module might be much easier. |
Contributor
Author
|
I pushed up 19af62a to move all the processing code into it's own file, |
AbhiPrasad
added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 27, 2025
…lts for every platform (#13832) resolves https://linear.app/getsentry/issue/LOGS-28 After testing with some SDKs and getting feedback, we've decided on a list of default attributes the SDKs should try to attach to logs. This includes 1. user attributes from https://develop.sentry.dev/sdk/data-model/event-payloads/user/ 2. browser attributes, parsed from user agents (getsentry/relay#4757) 3. os and device attributes attached to mobile, desktop, and native sdks, based on https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/ I also re-organized this section to make things a bit more clear. --------- Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Dav1dde
approved these changes
May 28, 2025
AbhiPrasad
added a commit
that referenced
this pull request
May 28, 2025
This was messed up when I rebased #4757 #skip-changelog
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2025
In #4757 we decided to attach browser name and version to logs. Right now for spans, we prefix browser information with `sentry.X`, see https://github.com/getsentry/sentry/blob/34c738613c9b39e3b0d64336d13b4551a4075c66/src/sentry/search/eap/spans/attributes.py#L334. This is causing inconsistencies between the queries for spans and logs, which is breaking the current queries for the logs view. Considering we are "enhancing" the data via relay, I think it makes sense to also add a `sentry.X` prefix for logs. This PR makes that change. resolves https://linear.app/getsentry/issue/LOGS-152
antonpirker
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
…lts for every platform (#13832) resolves https://linear.app/getsentry/issue/LOGS-28 After testing with some SDKs and getting feedback, we've decided on a list of default attributes the SDKs should try to attach to logs. This includes 1. user attributes from https://develop.sentry.dev/sdk/data-model/event-payloads/user/ 2. browser attributes, parsed from user agents (getsentry/relay#4757) 3. os and device attributes attached to mobile, desktop, and native sdks, based on https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/ I also re-organized this section to make things a bit more clear. --------- Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
bitsandfoxes
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
…lts for every platform (#13832) resolves https://linear.app/getsentry/issue/LOGS-28 After testing with some SDKs and getting feedback, we've decided on a list of default attributes the SDKs should try to attach to logs. This includes 1. user attributes from https://develop.sentry.dev/sdk/data-model/event-payloads/user/ 2. browser attributes, parsed from user agents (getsentry/relay#4757) 3. os and device attributes attached to mobile, desktop, and native sdks, based on https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/ I also re-organized this section to make things a bit more clear. --------- Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've received feedback externally and internally that users want to see browser information attached to their frontend logs. This matches behaviour that already exists in other data types like spans and errors (events) in the product.
To accomplish this, we generate new attributes on the log based on the incoming user agent and client hints. This matches the approach we take with spans and errors.
We set these via two new attributes,
browser.nameandbrowser.version. This is documented in the conventions here:resolves https://linear.app/getsentry/issue/LOGS-133