chore(feedback): rm user-feedback-ingest rollout flag#4076
Merged
Conversation
Dav1dde
previously requested changes
Sep 26, 2024
Member
Dav1dde
left a comment
There was a problem hiding this comment.
The uap-core module is changed in the PR. I assume you did not locally update the submodule and commit the old state.
loewenheim
approved these changes
Sep 26, 2024
Dav1dde
reviewed
Sep 26, 2024
Co-authored-by: David Herberth <david.herberth@sentry.io>
jjbayer
reviewed
Sep 26, 2024
Dav1dde
approved these changes
Sep 26, 2024
relay-dynamic-config/src/feature.rs
Outdated
| where | ||
| T: IntoIterator<Item = Feature>, | ||
| { | ||
| /// Only used for tests. |
Member
There was a problem hiding this comment.
Should we make it #[cfg(test)]?
This reverts commit e007ef3.
aliu39
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 3, 2024
Removes this rollout flag since user feedback is GA'd. Applies the options denylist directly (it was previously checked in the flag [handler](https://github.com/getsentry/getsentry/blob/50d26987b5095171e0a8f4342b78c3393660d880/getsentry/features.py#L1504-L1515)). Checks the denylist in the shim function. I think this is a better place to check it - previously we were missing a spot in post-process PR making this change safe for internal and external (self hosted) relays: getsentry/relay#4076
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref getsentry/sentry#78097
#skip-changelog