ci: update actions/upload-artifact to v4 with merge#4042
Merged
Conversation
Member
Author
|
Here's a successful binary release run that results in the same unified artifact named {{ github.sha }}: https://github.com/getsentry/relay/actions/runs/10910443909?pr=4042 |
jjbayer
approved these changes
Sep 18, 2024
Dav1dde
approved these changes
Sep 18, 2024
This reverts commit 3101053.
jjbayer
pushed a commit
that referenced
this pull request
Sep 30, 2024
f/u fix to #4042 where i forgot to test build_library error: https://github.com/getsentry/relay/actions/runs/11066500568/job/30747853032 successful build: https://github.com/getsentry/relay/actions/runs/11075417230?pr=4082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3876 by using artifacts/merge to merge together multiple artifacts from different jobs into the single one named github.sha that craft expects.
Summarily, upload-artifact v3 is deprecated but v4 doesn't support mutating an artifact with the name name by uploading different filepaths to the same artifact. Because we need a single artifact "github.sha", we have to use actions/merge to create it. Alternatively craft could be modified but this is the easiest way forward and I like the idea of a unified artifact, it makes craft simpler.
ref: getsentry/craft#552
#skip-changelog