ref(processing/store): remove references to feedback attachments option#3617
Merged
ref(processing/store): remove references to feedback attachments option#3617
Conversation
Member
Author
Unlike 3604, this is the same for self-hosted! The change is backwards-compatible with older SDK versions, as we'll still process feedback and attachments in separate envelopes, even with the flag enabled |
Dav1dde
approved these changes
May 21, 2024
Member
Dav1dde
left a comment
There was a problem hiding this comment.
Should also remove feedback.ingest-inline-attachments from Sentry now.
aliu39
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up after https://github.com/getsentry/team-replay/issues/393. We've set the option to true for all regions and tested that it works, so this is a dead code path we can remove
Relates to getsentry/sentry-javascript#11428
#skip-changelog