Revert "feat(server): Org rate limit per metric bucket"#2821
Merged
Conversation
This reverts commit 8353064.
iker-barriocanal
approved these changes
Dec 6, 2023
Dav1dde
approved these changes
Dec 6, 2023
Member
Author
|
@TBS1996 before we ship this again, let's figure out why Relay produced outcomes with this data category at all if no quota config was configured for it yet. After that I recommend the order:
|
TBS1996
added a commit
that referenced
this pull request
Dec 7, 2023
we had an incident when deploying #2758 because we unexpextedly sent outcomes of type ItemBucket without having updated sentry. This PR only adds the new datacategory so we can properly synchronize on both ends before adding the business logic. #2821 (comment)
jjbayer
added a commit
that referenced
this pull request
Dec 13, 2023
part of: #2716 in order to protect our kafka metric consumers, we want to have a way of rate limiting based on the amount of buckets, as that's what decides the load placed on our kafka topics. We are starting out with just the org throughput limits but will be expanded upon further as outlined in the linked epic. This is a re-revert of #2758 (reverted in #2821). --------- Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2758
This was deployed before sentry updated librelay, so sentry crashed with unknown data category.
#skip-changelog