Skip to content

fix(replays): Enforce rate limits#1877

Merged
jan-auer merged 5 commits intomasterfrom
fix/replay-rate-limit-enforcement
Feb 24, 2023
Merged

fix(replays): Enforce rate limits#1877
jan-auer merged 5 commits intomasterfrom
fix/replay-rate-limit-enforcement

Conversation

@jjbayer
Copy link
Member

@jjbayer jjbayer commented Feb 23, 2023

Rate limits for replays were checked but not enforced. See test case.

@jjbayer jjbayer requested review from a team, cmanallen and jan-auer February 23, 2023 16:13
jjbayer and others added 2 commits February 23, 2023 17:54
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
@jan-auer
Copy link
Member

Moving ahead with this as the monthly quota is not counted through these rate limits. We need to follow up with correct counting, however.

@jan-auer jan-auer merged commit d66c8c5 into master Feb 24, 2023
@jan-auer jan-auer deleted the fix/replay-rate-limit-enforcement branch February 24, 2023 09:51
jan-auer added a commit that referenced this pull request Feb 24, 2023
* master:
  build: Upgrade sentry SDK to 0.30.0 (#1883)
  chore(metrics): Remove satisfaction thresholds (#1881)
  feat(profiling): Add javascript platform (#1876)
  fix(replays): Enforce rate limits (#1877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants