ref(server): Split EnvelopeManager file into smaller parts#1388
Merged
ref(server): Split EnvelopeManager file into smaller parts#1388
Conversation
* master: ref(metrics): Remove `light_normalize` in favor of `light_normalize_event` (#1385)
flub
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file containing
EnvelopeManagerdefined two other major components: First,the
EnvelopeProcessorwhich made up most of the file's contents and containsall synchronous processing code calling out to the normalization libraries.
Second, the
EnvelopeContextwhich comprises relevant information to carryalong with Envelopes.
This PR separates all of these components into their own files so that changes
to the
EnvelopeManager's internals can be reviewed better. The precise changesare:
EnvelopeProcessoralong with all its messages into a dedicated fileEnvelopeContextintoutils::with_outcome, which is what it isintended for.
EncodeEnvelope. This processing function cansubsequently be removed.
There is no change to control flow or behavior of any involved components.
#skip-changelog