ref(metrics): Remove light_normalize in favor of light_normalize_event#1385
Merged
iker-barriocanal merged 2 commits intomasterfrom Aug 8, 2022
Merged
ref(metrics): Remove light_normalize in favor of light_normalize_event#1385iker-barriocanal merged 2 commits intomasterfrom
light_normalize in favor of light_normalize_event#1385iker-barriocanal merged 2 commits intomasterfrom
Conversation
`light_normalize` makes two calls: transaction validation, and light normalizing the event. There is nothing stopping transaction validation to be done in the same function the event is normalized. This makes removing the `light_normalize` wrapper possible.
light_normalize in favor of light_normalize_event
untitaker
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1366 (comment).
light_normalizemakes two calls: transaction validation, and lightnormalizing the event. There is nothing stopping transaction validation
to be done in the same function the event is normalized. This makes
removing the
light_normalizewrapper possible.The PR removes
light_normalizeand updates all references to uselight_normalize_event.#skip-changelog