fix(unreal): Don't drop event in PoP relays [INC-181] [ISSUE-1558]#1355
Merged
fix(unreal): Don't drop event in PoP relays [INC-181] [ISSUE-1558]#1355
Conversation
metrics extraction errors in pops if there is no event in the envelope. This at least impacts Unreal events, but potentially more event types where `creates_event` is True without there actually being an event in the envelope (minidumps?)
iker-barriocanal
approved these changes
Jul 28, 2022
jan-auer
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metrics extraction errors in pops if there is no event in the envelope.
This at least impacts Unreal events, but potentially more event types
where
creates_eventis True without there actually being an event inthe envelope.