This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: dont throw if profiler returns nulptr#197
Merged
Conversation
JonasBa
commented
Sep 5, 2023
| // if that title had somehow been stopped already, profile will be null. | ||
| status = ProfileStatus::kStopped; | ||
|
|
||
| if (!profile) { |
abf4899 to
8b105d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the throw call added in https://github.com/getsentry/profiling-node/pull/187/files#r1316130323 and unblocks #196
I did not manage to find a root cause quickly so I am removing the throw call in order to unblock users (it was added recently). I've looked through the timeout logic and did not find any issues (I have added some more tests). Since nulptr is a valid return from the profiler we should just handle it gracefully anyways