This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: use gnu aarch compiler for arm64 binary#172
Merged
JonasBa merged 1 commit intogetsentry:mainfrom Jul 5, 2023
bohdanw2:b/fix/arm64-cross-compilation
Merged
fix: use gnu aarch compiler for arm64 binary#172JonasBa merged 1 commit intogetsentry:mainfrom bohdanw2:b/fix/arm64-cross-compilation
JonasBa merged 1 commit intogetsentry:mainfrom
bohdanw2:b/fix/arm64-cross-compilation
Conversation
Contributor
Author
|
This will most likely fix #168 |
Member
|
Thanks for the contribution @bohdanw2, we'll release this today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite having
BUILD_ARCH=arm64 npm run build:bindings:arm64step for arm64 precompiled binary final artifact is still ofx86-64format:Apple silicon (docker):
yarn add @sentry/profiling-node --ignore-scripts file node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-arm64-glibc-93.node node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-arm64-glibc-93.node: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=df0bbf4844a088ba62b7f53a722cbc646a697a15, not stripped ldd node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-arm64-glibc-93.node not a dynamic executableThis PR enforces node-gyp to cross compile binaries using already installed gnu compiler.
file node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-arm64-glibc-93.node node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-arm64-glibc-93.node: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, BuildID[sha1]=82e0cca86e11898652576d0a0f7df1a94e11147b, not stripped ldd node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-arm64-glibc-93.node linux-vdso.so.1 (0x0000ffffa6eb2000) libstdc++.so.6 => /lib/aarch64-linux-gnu/libstdc++.so.6 (0x0000ffffa6c30000) libpthread.so.0 => /lib/aarch64-linux-gnu/libpthread.so.0 (0x0000ffffa6c00000) libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffffa6a50000) /lib/ld-linux-aarch64.so.1 (0x0000ffffa6e75000) libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000ffffa69b0000) libgcc_s.so.1 => /lib/aarch64-linux-gnu/libgcc_s.so.1 (0x0000ffffa6970000)