Skip to content

Remove tree-sitter and associated build infrastructure #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spalmurray merged 6 commits into from
May 15, 2025
Merged

Remove tree-sitter and associated build infrastructure #19

spalmurray merged 6 commits into from
May 15, 2025

Conversation

@spalmurray
Copy link
Collaborator

@spalmurray spalmurray commented May 12, 2025

Reapplies @Swatinem's diff from codecov/codecov-cli#664

@spalmurray spalmurray marked this pull request as ready for review May 12, 2025 18:56
spalmurray added a commit that referenced this pull request May 13, 2025
@spalmurray
Remove missed files from #19
6497514
@codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
6870 10 6860 10
View the top 3 failed test(s) by shortest run time 
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@spalmurray spalmurray force-pushed the swatinem/rm-treesitter branch from 6497514 to 5f01a8e Compare May 13, 2025 15:23
@spalmurray spalmurray force-pushed the swatinem/rm-treesitter branch from 5956ac6 to 50d8d47 Compare May 14, 2025 20:41
joseph-sentry
joseph-sentry approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, are u manually pulling changes in from the original branch or are you able to automate this somewhat

@spalmurray
Copy link
Collaborator Author

spalmurray commented May 14, 2025

did this one manually, but I think I did a previous one with some combination of git commands

@spalmurray spalmurray merged commit 1924bce into main May 15, 2025
27 checks passed
@spalmurray spalmurray deleted the swatinem/rm-treesitter branch May 15, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Swatinem Swatinem Swatinem approved these changes

@joseph-sentry joseph-sentry joseph-sentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spalmurray @Swatinem @joseph-sentry