feat(rule): Forbid importing directly from main module#46
Merged
Conversation
Instead, import the specific module. e.g.
Member
Author
billyvg
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 13, 2019
Undoes the work introduced in #5616. This plugin adds around 40-50 seconds to webpack build times and has caused confusion (see #13834). Also adds an eslint rule to prevent importing `lodash` bundle: getsentry/eslint-config-sentry#46 | -- | With Plugin | Without Plugin | Difference | lodash-es | lodash-es + react-mentions | | -- | ----------- | -------------- | ---------- | --------- | - | | app.js | 739051 | 739120 | 0% | | | | app.js.gzip | 184017 | 184040 | 0% | | 186949 | | vendor.js | 2076311 | 2090876 | +0.7% | 2089352 | | vendor.js.gizp | 375718 | 380446 | + 1.2% | 380630 | 380476 | | build time (w/ stats) | 316s | 466s | + 47% | | | build time (env=prod) | 335s | 198s | n/a | | Currently, there is no sizable difference between `lodash-es` and `lodash` -- we should revisit this in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, import the specific module. e.g.
import isEqual from 'lodash/isEqual'