Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented May 4, 2021

Inspired by facebook/create-react-app#10083. prompts is a modern and
lighter alternative to inquirer and it is almost a drop-in
replacement. This change shaves off 0.7MB from our minified builds.

Inspired by facebook/create-react-app#10083. `prompts` is a modern and
lighter alternative to `inquirer` and it is almost a drop-in
replacement. This change shaves off 0.7MB from our minified builds.
@BYK BYK requested review from chadwhitacre, jan-auer and tonyo May 4, 2021 15:25
Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but seems reasonable.

@BYK BYK closed this May 4, 2021
@BYK BYK reopened this May 4, 2021
@BYK BYK merged commit 1f661f6 into master May 4, 2021
@BYK BYK deleted the byk/ref/inquirer-prompt branch May 4, 2021 17:48
BYK added a commit that referenced this pull request May 5, 2021
* ref(inquirer): Replace inquirer with prompts

Inspired by facebook/create-react-app#10083. `prompts` is a modern and
lighter alternative to `inquirer` and it is almost a drop-in
replacement. This change shaves off 0.7MB from our minified builds.

* ref: Lint fixes

* add @types/prompts

* remove obsolete function

Co-authored-by: getsentry-bot <bot@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants