Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2020

Bumps handlebars from 4.1.2 to 4.7.6.

Changelog

Sourced from handlebars's changelog.

v4.7.6 - April 3rd, 2020

Chore/Housekeeping:

Compatibility notes:

  • Restored Node.js compatibility

Commits

v4.7.5 - April 2nd, 2020

Chore/Housekeeping:

  • Node.js version support has been changed to v6+ Reverted in 4.7.6

Compatibility notes:

  • Node.js < v6 is no longer supported Reverted in 4.7.6

Commits

v4.7.4 - April 1st, 2020

Chore/Housekeeping:

Compatibility notes:

  • No incompatibilities are to be expected

Commits

v4.7.3 - February 5th, 2020

Chore/Housekeeping:

  • #1644 - Download links to aws broken on handlebarsjs.com - access denied (@Tea56)
  • Fix spelling and punctuation in changelog - d78cc73

Bugfixes:

  • Add Type Definition for Handlebars.VERSION, Fixes #1647 - 4de51fe
  • Include Type Definition for runtime.js in Package - a32d05f

Compatibility notes:

Commits
Maintainer changes

This version was pushed to npm by erisds, a new releaser for handlebars since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @jan-auer.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 4, 2020
@jan-auer
Copy link
Member

@dependabot squash and merge

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/handlebars-4.7.6 branch from bb820c2 to 79db10d Compare September 21, 2020 08:11
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2020

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot dependabot bot merged commit b35c34d into master Sep 21, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/handlebars-4.7.6 branch September 21, 2020 08:20
BYK added a commit that referenced this pull request Nov 24, 2025
When formatting PR entries for the changelog, the PR number like '(#123)'
at the end of the title is now stripped since the PR link is already
included at the end of the entry.
BYK added a commit that referenced this pull request Nov 24, 2025
When formatting PR entries for the changelog, the PR number like '(#123)'
at the end of the title is now stripped since the PR link is already
included at the end of the entry.
BYK added a commit that referenced this pull request Nov 24, 2025
When formatting PR entries for the changelog, the PR number like '(#123)'
at the end of the title is now stripped since the PR link is already
included at the end of the entry.
BYK added a commit that referenced this pull request Nov 24, 2025
* Refactor changelog generation to use release.yml for categorization

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Fix: Handle ENOENT error and improve changelog generation

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Refactor: Improve changelog generation tests

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Fix failing tests (#625)

* Refactor: Improve changelog generation and mock fs

This commit refactors the changelog generation logic to correctly handle category-level exclusions and improves the mocking of the `fs` module by using `jest.requireActual` for `readFileSync`. It also updates the `gcsAPI` tests to use the mocked `fs.existsSync`.

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* chore: Remove package-lock.json and regenerate yarn.lock

- Remove npm-generated package-lock.json file
- Regenerate yarn.lock with current dependencies
- Project uses yarn as the package manager

* fix: Resolve all TypeScript compilation and test failures

Fixed multiple TypeScript compilation errors and dependency issues:

**TypeScript Fixes:**
- Fixed github.ts: Changed Promise resolve callback to match expected signature
- Fixed awsLambdaLayerManager.ts:
  - Added Runtime import and cast CompatibleRuntimes to Runtime[]
  - Cast headers to Record<string, string> for fetch compatibility
- Fixed registry.ts: Added explicit RemoteArtifact type to mapLimit callback
- Fixed brew.ts: Added RemoteArtifact import and type annotation

**Configuration Fixes:**
- tsconfig.build.json: Added noImplicitUseStrict: false to override deprecated parent config option
- jest.config.js: Added transformIgnorePatterns for ESM modules (dot-prop, configstore)
- package.json: Pinned dot-prop to ^5.3.0 to avoid ESM-only version 10.x that breaks Jest

**Test Results:**
- All 38 test suites passing ✅
- 369 tests passing, 1 skipped (370 total)
- 28 snapshots passing

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

* Refactor changelog generation to use GitHub PR format

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Refactor changelog generation to use Sets for exclusions

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Refactor: Normalize release config exclusions to use empty sets

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Refactor: Simplify changelog normalization and matching logic

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Refactor: Simplify changelog exclusion logic and update yarn.lock

This commit refactors the changelog exclusion logic to be more concise and removes unnecessary checks. It also updates the yarn.lock file to reflect the latest dependency versions.

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Checkpoint before follow-up message

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* Refactor changelog generation and update tsconfig

Co-authored-by: burak.kaya <burak.kaya@sentry.io>

* build(deps-dev): bump js-yaml from 4.1.0 to 4.1.1 (#624)

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump js-yaml from 3.13.1 to 4.1.1 (#626)

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.1 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@3.13.1...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Upgrade sentry/node to latest (#627)

* chore: Upgrade sentry/node to latest

* fix

* fix: Upgrade Jest to 29.7.0 to fix ESM/CJS compatibility with Node 22

The older Jest version had issues with strip-ansi ESM module resolution
when running on Node.js 22. Also added a resolution to pin strip-ansi
in @jest/reporters to the CJS-compatible version.

* fix: Remove corrupted 'yarn' prefix from test file

Rebase artifact left 'yarn' prefix on a line in the test file.

* fix: Replace Set.intersection() with loop for Node 20 compatibility

Set.intersection() is only available in Node 22+. Use a loop to check
for excluded labels instead.

* fix: Strip redundant PR number suffix from PR titles in changelog

When formatting PR entries for the changelog, the PR number like '(#123)'
at the end of the title is now stripped since the PR link is already
included at the end of the entry.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
BYK added a commit that referenced this pull request Dec 26, 2025
## Summary

Adds a new `craft changelog` CLI command and a reusable GitHub Actions
workflow that previews how PRs will appear in the changelog.

## New CLI Command

```bash
# Generate changelog from latest tag
craft changelog

# Generate changelog with PR preview (highlighted)
craft changelog --pr 123

# Output as JSON (includes bumpType for automation)
craft changelog --pr 123 --format json
```

### JSON Output
```json
{
  "changelog": "### New Features ✨\n\n> - feat: Add feature by @user in #123",
  "bumpType": "minor",
  "totalCommits": 15,
  "matchedCommitsWithSemver": 12
}
```

## Reusable Workflow

Other repos can use the changelog preview by adding:

```yaml
name: Changelog Preview
on:
  pull_request:
    types: [opened, synchronize, reopened, edited, labeled]

jobs:
  changelog-preview:
    uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2
    secrets: inherit
```

### Features
- Shows suggested version bump (major/minor/patch) based on commit
categories
- Highlights PR entries with blockquote style
- Auto-updates when PR is modified (title, description, labels, commits)

### Example Comment

![image](https://github.com/user-attachments/assets/placeholder)

## Architecture

Refactored changelog generation into clean separation of concerns:

1. **fetchRawCommitInfo** - Fetches commit/PR data from git and GitHub
2. **categorizeCommits** - Groups commits into categories with bump type
detection
3. **serializeChangelog** - Renders to markdown

The `generateChangelogWithHighlight` function uses a "sandwich"
approach:
1. Fetch raw commits up to base branch
2. Add current PR with `highlight: true`
3. Run categorization on combined list
4. Serialize to markdown

## Files Changed

- `src/commands/changelog.ts` - New CLI command
- `src/utils/changelog.ts` - Refactored with new architecture
- `.github/workflows/changelog-preview.yml` - Reusable workflow
- `install/action.yml` - Shared Craft installation action
- `docs/src/content/docs/github-actions.md` - Documentation
- `README.md` - Updated with GitHub Actions section
cursor bot pushed a commit that referenced this pull request Jan 13, 2026
The changelog preview was creating markdown links to PRs like
[#123](url), which caused GitHub to automatically post a comment
on each mentioned PR saying it was referenced. This was noisy
since the PRs don't usually have anything in common other than
being in the same release.

This change adds a `disablePRLinks` parameter that formats PR
references using backticks (`#123`) instead of markdown links,
preventing GitHub from auto-linking and creating cross-references.

The fix is applied specifically to the changelog preview feature
(used in the GitHub Actions workflow) by passing `disablePRLinks: true`
when calling `serializeChangelog()` from `generateChangelogWithHighlight()`.

Regular changelog generation (for actual releases) continues to use
full markdown links as before.

Fixes #78da
BYK added a commit that referenced this pull request Jan 13, 2026
Disable PR links in changelog previews to prevent unwanted GitHub
cross-references.

The changelog preview feature (e.g., `craft changelog --pr`) was
generating markdown links for PRs, which caused GitHub to create
cross-reference notifications on those PRs. This change formats PR
numbers as plain backticked text (e.g., `` `#123` ``) in previews,
avoiding the unwanted notifications while keeping full links for actual
release changelogs.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants