Skip to content

No tests in bdist#1618

Closed
ionelmc wants to merge 9 commits into
getpelican:masterfrom
ionelmc:no-tests-in-bdist
Closed

No tests in bdist#1618
ionelmc wants to merge 9 commits into
getpelican:masterfrom
ionelmc:no-tests-in-bdist

Conversation

@ionelmc

@ionelmc ionelmc commented Feb 8, 2015

Copy link
Copy Markdown
Contributor

Discussion from IRC:

18:38 <ionelmc> can you stop including the tests in the installed package?
18:39 <+justmay> Fine with me. Care to submit a PR that addresses that?
18:39 <ionelmc> sure
18:47 <ionelmc> justmay: is `.mailmap` a stray file?
18:47 <ionelmc> look like your sdist is incomplete
18:48 <ionelmc> doesn't include all the docs and test conf
18:50 <ionelmc> justmay: oh snap. i have to move out the tests to fix this :-)
18:51 <ionelmc> because include_package_data is used any included data file overlaying the package is going into the bdist
18:51 <+justmay> ionelmc: .mailmap is there by design. See "Mapping Authors": https://www.kernel.org/pub/software/scm/git/docs/git-shortlog.html
18:52 <ionelmc> mkay
18:52 <ionelmc> justmay: you're not going to have a problem with the tests dir at the same level as pelican package right?
18:53 → e-Flex joined (~e-Flex@h-62-241.a259.priv.bahnhof.se)
18:54 <+justmay> There's no other way to prevent inclusion of tests in the installed package?
18:55 <ionelmc> justmay: there are two horrible ways
18:55 <ionelmc> don't include it in the sdist (highly undesirable)
18:55 <ionelmc> or
18:55 <ionelmc> manually specify package_data 
18:55 <ionelmc> which i can do it correctly for you know, but it will be error prone to maintain
18:56 <ionelmc> s/know/now/
18:56 <ionelmc> i think that's also not desirable
18:56 <ionelmc> that's why i think moving them out is ok
18:57 <ionelmc> i'll fix the test configuration to work that way
18:57 <ionelmc> justmay: agree? :-)
18:59 <+justmay> ionelmc: Quite honestly, I don't have the bandwidth this morning to dig deeply enough into this topic. Would you submit an issue so we (i.e., the community) can discuss this and come to a consensus?
19:00 <ionelmc> justmay: there's already https://github.com/getpelican/pelican/issues/1409 - i seriously doubt a new issue will help in any way
19:01 <winlu> ionelmc: justs prune tests and be done with it
19:01 <ionelmc> justmay: it's either the relocation or manual package_data, make a choice :-)
19:01 <ionelmc> winlu: pruning the tests will remove them from sdist

Closes #1609. Closes #1545. Closes #1409.

@justinmayer

justinmayer commented Feb 17, 2015

Copy link
Copy Markdown
Member

@ionelmc: With these changes, it would seem that Travis is not running tests. (Hat tip to @avaris for noticing this!)

@ionelmc

ionelmc commented Feb 17, 2015

Copy link
Copy Markdown
Contributor Author

Good catch but Coveralls does this automatically for you 😉

If you enable it I'll add configuration for it.

@ionelmc

ionelmc commented Feb 18, 2015

Copy link
Copy Markdown
Contributor Author

Mkay, there are some merge conflicts ....

@ionelmc

ionelmc commented Feb 18, 2015

Copy link
Copy Markdown
Contributor Author

Rebased now. @justinmayer seems coveralls isn't reporting any build status. Can you check? Maybe you just need to reauth with coveralls.

@ingwinlu

ingwinlu commented Apr 17, 2015

Copy link
Copy Markdown
Contributor

the move to a more traditional split of packages is what mainly does it for me, i.e. move tests out of the pelican directory.
If you look at other python projects it would be even more expected to not have pelican_tests but just tests.

the changes to the sdists and bdists also would also help the ongoing effort to make pelican play nice with windows.

@ionelmc

ionelmc commented May 11, 2015

Copy link
Copy Markdown
Contributor Author

@justinmayer Any updates here? It's not clear what you're waiting for.

@ionelmc

ionelmc commented May 18, 2015

Copy link
Copy Markdown
Contributor Author

I've been thinking, maybe we should have something like this: https://bitbucket.org/pypa/setuptools/pull-request/133/dont-install-tests-in-site-packages/diff

@ingwinlu

ingwinlu commented May 28, 2015

Copy link
Copy Markdown
Contributor

this won't be looked at until it at least confirms with what we require of pull requests: http://pelican.readthedocs.org/en/latest/contribute.html#using-git-and-github

@ionelmc

ionelmc commented May 28, 2015

Copy link
Copy Markdown
Contributor Author

It's not clear what you're asking of.

On Thursday, May 28, 2015, winlu notifications@github.com wrote:

this won't be looked at until it at least confirms with what we require of
pull requests:
http://pelican.readthedocs.org/en/latest/contribute.html#using-git-and-github

—
Reply to this email directly or view it on GitHub
#1618 (comment).

Thanks,
-- Ionel Cristian Mărieș, http://blog.ionelmc.ro

@justinmayer justinmayer mentioned this pull request Jun 16, 2015
Closed
@justinmayer justinmayer added this to the 3.6.1 milestone Jun 16, 2015
@justinmayer

justinmayer commented Jun 22, 2015

Copy link
Copy Markdown
Member

@ionelmc: Is there an advantage to relocating the tests to /pelican_tests as opposed to /tests? The latter appears to be a more common pattern.

@ionelmc

ionelmc commented Jun 22, 2015

Copy link
Copy Markdown
Contributor Author

@justinmayer The advantage was me not having to rework all the imports in the tests :-)

I can redo this, and have them in a tests directory but you have to pledge that you merge this.

@justinmayer

justinmayer commented Jun 22, 2015

Copy link
Copy Markdown
Member

Already planning on merging it, as noted by the 3.6.1 milestone I added last week. When you rebase on current master and make your changes, would you take a moment to squash into discrete commits?

Really appreciate all your help with this. It'll be nice to resolve the aforementioned problems related to this issue.

@ionelmc

ionelmc commented Jun 22, 2015

Copy link
Copy Markdown
Contributor Author

I don't think I can rebase this. Git not smart enough to deal with renames in rebase - I have to redo it.

@justinmayer

justinmayer commented Jun 22, 2015

Copy link
Copy Markdown
Member

Good point. Thanks again for all your assistance with this effort.

@justinmayer

justinmayer commented Jul 9, 2015

Copy link
Copy Markdown
Member

Hi @ionelmc. Just checking in... Any chance you might find the time to implement the changes we talked about a couple weeks ago?

ionelmc added a commit to ionelmc/pelican that referenced this pull request Jul 9, 2015
@ionelmc
Avoid adding the tests in bdists (like wheel bdist). Supersedes and c…
bd5dfa0 
…loses getpelican#1618.
@ionelmc ionelmc mentioned this pull request Jul 9, 2015
Merged
@ionelmc

ionelmc commented Jul 9, 2015

Copy link
Copy Markdown
Contributor Author

Ok. Figured out a smarter (or simpler) fix in #1778.

@justinmayer justinmayer removed this from the 3.6.1 milestone Jul 10, 2015
andreacorbellini pushed a commit to andreacorbellini/pelican that referenced this pull request Jul 30, 2015
@ionelmc @andreacorbellini
Avoid adding the tests in bdists (like wheel bdist). Supersedes and c…
e4b4808 
…loses getpelican#1618.
andreacorbellini pushed a commit to andreacorbellini/pelican that referenced this pull request Jul 30, 2015
@ionelmc @andreacorbellini
Avoid adding the tests in bdists (like wheel bdist). Supersedes and c…
7e8ea16 
…loses getpelican#1618.
number5 added a commit to number5/pelican that referenced this pull request Aug 8, 2015
@number5
Merge remote-tracking branch 'upstream/master' into wphacks
771e6b8 
* upstream/master: (53 commits)
  Prepare version 3.6.3.dev for next development cycle
  Bump version 3.6.2
  Update changelog
  Avoid adding the tests in bdists (like wheel bdist). Supersedes and closes getpelican#1618.
  Update tips.rst
  Watch for changes in mtime of symlinked folders and files too
  improve URLWrapper comparison
  remove PAGES; use pages instead
  Document enabling per-block Markdown line numbers
  Update simple theme to fix getpelican#1068
  Fixes getpelican#1068, getpelican#1572: template page navigation bugs
  Export hidden pages in context
  keep docs output
  Prepare version 3.6.1.dev for next development cycle
  Bump version 3.6.0
  Minor fixes to 3.6 release changelog
  Update changelog for imminent 3.6 release
  Remove references to easy_install in documentation
  Match space with POSIX sed when bumping via bumpr
  Include setup.py when bumping version number
  ...
mvdoc added a commit to mvdoc/pelican that referenced this pull request Feb 22, 2016
@mvdoc
Merge branch 'master' of github.com:getpelican/pelican
11bd171 
* 'master' of github.com:getpelican/pelican: (154 commits)
  Avoid adding the tests in bdists (like wheel bdist). Supersedes and closes getpelican#1618.
  Update tips.rst
  Watch for changes in mtime of symlinked folders and files too
  improve URLWrapper comparison
  Document enabling per-block Markdown line numbers
  Update simple theme to fix getpelican#1068
  Fixes getpelican#1068, getpelican#1572: template page navigation bugs
  Export hidden pages in context
  keep docs output
  Prepare version 3.6.1.dev for next development cycle
  Bump version 3.6.0
  Minor fixes to 3.6 release changelog
  Update changelog for imminent 3.6 release
  Remove references to easy_install in documentation
  Match space with POSIX sed when bumping via bumpr
  Include setup.py when bumping version number
  Fix getpelican#1647: Fix ARTICLE_ORDER_BY and add the ability to reverse order
  fix outdated content_object_init refs
  set default for caching to false
  fix caching
  ...
@avaris avaris mentioned this pull request Oct 13, 2019
Closed
@justinmayer justinmayer mentioned this pull request May 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@ionelmc @justinmayer @ingwinlu