Prevent crashes if OSMDroidMapFragment is destroyed before view is created#7108
Merged
grzesiek2010 merged 1 commit intogetodk:v2026.1.xfrom Feb 20, 2026
Merged
Prevent crashes if OSMDroidMapFragment is destroyed before view is created#7108grzesiek2010 merged 1 commit intogetodk:v2026.1.xfrom
grzesiek2010 merged 1 commit intogetodk:v2026.1.xfrom
Conversation
grzesiek2010
approved these changes
Feb 20, 2026
|
The apk isn't available in https://github.com/getodk/collect/commits/v2026.1.x |
Member
Author
|
@dbemke building now! |
|
Tested with success Verified on device with Android 16 Verified cases:
|
|
Tested with success Verified on device with Android 10 |
seadowg
pushed a commit
to seadowg/collect
that referenced
this pull request
Mar 4, 2026
Prevent crashes if OSMDroidMapFragment is destroyed before view is created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7051
Why is this the best possible solution? Were any other approaches considered?
This was a pretty simple fix once I'd worked out the problem: the OSM map implementation would hit a
NullPointerExceptionwhen being destroyed due to an Activity being finished early in this scenario because the view might not have been created yet.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Just a very small change to just OSM, so nothing else needs looked at.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest