Update info in geoshape/trace#7074
Conversation
|
@alyblenkin let me know if this looks correct now! One question I had: we currently show the placement mode options when no input method is selected yet (before any data is entered). Should we potentially just hide the info button in this state? |
|
Thank you!
I think it's ok to default to placement mode for the dialog content. For someone exploring and testing, it's helpful to see the info button. They can't make a mistake by tapping either or following the instructions anyway. Ideally we would have some way to emphasize the marker button as the first call to action. We could actually change the primary CTA to the "Add" marker button instead of "saved" when they land on the map, but maybe that's beyond scope for now. |
Update info in geoshape/trace
|
Tested with Success! Verified on device with Android 12, 14 Verified cases:
|
|
Tested with Success! Verified on device with Android 10 |
|
Tested with Success! Verified on device with Android 16 |
Closes #7070
Why is this the best possible solution? Were any other approaches considered?
This just updates the info based on feedback from @alyblenkin. Nothing to discuss!
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The info dialog is the only thing that's been touched.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest