Improve scrolling to questions and highlighting questions with errors#7064
Merged
seadowg merged 3 commits intogetodk:v2026.1.xfrom Feb 5, 2026
Merged
Improve scrolling to questions and highlighting questions with errors#7064seadowg merged 3 commits intogetodk:v2026.1.xfrom
seadowg merged 3 commits intogetodk:v2026.1.xfrom
Conversation
seadowg
approved these changes
Feb 3, 2026
Member
seadowg
left a comment
There was a problem hiding this comment.
I like this! It's probably worth waiting for behaviour verified to merge this as it's an easy area to create regressions in.
|
Tested with Success! Verified on devices with Android 10 Verified cases:
|
|
Tested with success Verified on Android 16 |
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Feb 10, 2026
Improve scrolling to questions and highlighting questions with errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7020
Why is this the best possible solution? Were any other approaches considered?
It seems that during some recent refactoring, we accidentally removed the logic that sets focus after highlighting a question with an error. I’ve fixed that, and also took the opportunity to make some improvements: we can now eliminate some
postDelayedcalls that were previously needed to ensure smooth scrolling to specific questions, which wasn’t working perfectly before so:How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Here, we need to test form validation, especially cases that require scrolling to a specific question to highlight it (please also test success validations to see if the snackbar is displayed correctly). Another important case is answering select one from map questions, to ensure that scrolling to those questions works correctly, see: #7028.
Do we need any specific form for testing your changes? If so, please attach one.
The form is linked in the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest