Block adding point when invalid#7052
Merged
grzesiek2010 merged 7 commits intogetodk:masterfrom Jan 30, 2026
Merged
Conversation
63ab2d6 to
8e90346
Compare
72a28d6 to
85672a5
Compare
seadowg
commented
Jan 30, 2026
| return LiveDataUtils.zip(this, other) | ||
| } | ||
|
|
||
| fun <T, U> LiveData<T>.runningFold(initial: U, operation: (U, T) -> U): LiveData<U> { |
Member
Author
There was a problem hiding this comment.
I'd probably have just referred to this as "fold", but on Flow that's used for an operation that waits for termination to give you a true fold of the whole stream - probably more correct. Good to be consistent between the two reactive types as well.
grzesiek2010
approved these changes
Jan 30, 2026
This was referenced Jan 30, 2026
|
Tested with success Verified on Android 16 Verified cases:
|
|
Tested with success Verified on Android 14 |
|
Tested with success Verified on Android 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6970
Blocked by #7021Blocked by #7050This removes the ability to add new points while the trace/shape is invalid and also:
Why is this the best possible solution? Were any other approaches considered?
Comments inline.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Just the new features here: no map code was affected so can be tested in any one of them.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest