Highlight shape/trace and disable save button when invalid#7050
Merged
grzesiek2010 merged 12 commits intogetodk:masterfrom Jan 28, 2026
Merged
Highlight shape/trace and disable save button when invalid#7050grzesiek2010 merged 12 commits intogetodk:masterfrom
grzesiek2010 merged 12 commits intogetodk:masterfrom
Conversation
c235176 to
02c940a
Compare
seadowg
commented
Jan 26, 2026
| null | ||
| } | ||
|
|
||
| fun Int.opaque(): Int { |
Member
Author
There was a problem hiding this comment.
Definitely useful to be able to use this for comparisons where the alpha doesn't matter.
seadowg
commented
Jan 26, 2026
| fun getStrokeColor(): Int | ||
| } | ||
|
|
||
| fun TraceDescription.getMarkersForPoints(): List<MarkerDescription> { |
Member
Author
There was a problem hiding this comment.
I'm hoping we can do more and more of this: pull logic into the "view data" layer so that it can be shared between the map engines and allow them to be as thin as possible. Ideally they shouldn't care at all about state or display logic and just render things.
grzesiek2010
requested changes
Jan 28, 2026
geo/src/main/java/org/odk/collect/geo/geopoly/GeoPolyFragment.kt
Outdated
Show resolved
Hide resolved
5da62de to
c265591
Compare
6 tasks
grzesiek2010
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #6970
This felt like enough to merge and possibly go out as a beta - I'll follow up with the rest of the issue.
Why is this the best possible solution? Were any other approaches considered?
Comments inline.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
As the title says this just adds the "invalid" style to traces and shapes (they should appear in red without the last point highlighted) and also disables the save button while constraints are violated. All three map engines should be working, but the changes are minimal so no need to dig in too deep.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest