sentry: disable client reports#1729
Merged
lognaturel merged 3 commits intogetodk:masterfrom Jan 22, 2026
Merged
Conversation
This is a workaround for unclean shutdown handling in Sentry SDK. See: getodk/central#1347
Member
|
I'm happy with the general approach. Perhaps we can file an issue to re-enable client reports once getsentry/sentry-javascript#18802 is fixed? |
lognaturel
approved these changes
Jan 20, 2026
Member
|
This has now been fixed and released upstream: getsentry/sentry-javascript#18808 But since we want to release an improvement in a point release and client reports are not that important, I think we should release this small change and file an issue to upgrade Sentry and reintroduce client reports. |
Member
lognaturel
pushed a commit
to lognaturel/central-backend
that referenced
this pull request
Jan 27, 2026
This is a workaround for unclean shutdown handling in Sentry SDK.
lognaturel
added a commit
that referenced
this pull request
Jan 27, 2026
Contributor
Author
I think this was resolved in Slack, and related to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for unclean shutdown handling in Sentry SDK.
See: getodk/central#1347
What has been done to verify that this works as intended?
Tested quite a bit manually locally.
Why is this the best possible solution? Were any other approaches considered?
I think the correct solution is to always call
Sentry.close(), but without relevant tests it will be:Sentry.close()is always called, andTests are also tricky to write, as the only reproduction I've found is by updating
/etc/hosts, so this bug would potentially need a new suite of tests, or at least an update to the existingstandardsuite. Ideally these tests would:lib/bin/, andodk-central-backendservice, and shut it downand then check that all of the above processes halted within a sensible timeframe.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should fix their issue with #1347
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes