Merged
Conversation
The test for SSLLabs implodes if a Common Name is not set for the cert served for incorrect domains. See: https://www.ssllabs.com/ssltest/analyze.html?d=production.getodk.cloud This is a test for the change made in getodk#1366
brontolosone
added a commit
to brontolosone/central-backend
that referenced
this pull request
Oct 24, 2025
…sequent POSTs (continuations of attachment uploads). Fixes getodk/central#1426
brontolosone
added a commit
to brontolosone/central-backend
that referenced
this pull request
Oct 24, 2025
…sequent POSTs (continuations of attachment uploads). Fixes getodk/central#1426
ktuite
added a commit
to getodk/central-backend
that referenced
this pull request
Dec 6, 2025
* add failing test: OpenRosa attachment addition submission is not auditlogged
* blobs: refactor ensure()
- Make inserting a blob which already exists a true no-op
(saves DB churn; the sha update of the replaced approach caused a row copy)
- Remove comment related to force-a-write-so-we-can-return-the-id
(as we do it differently now)
- Remove comment about avoiding a TOCTOU issue by sending the file over
(potentially unnecessarily).
1. There was almost a TOCTOU issue anyway, but it was elided by
touching every used row, which makes concurrent deleters/updaters
of that row block until our transaction commit.
2. Avoiding sending the file over *and* avoiding a TOCTOU should be
doable with a row lock or advisory lock.
* OpenRosa submissions: auditlog updates to attachment set, also on subsequent POSTs (continuations of attachment uploads). Fixes getodk/central#1426
* Handle resubmitting or altering attachment when resending submission with missing attachment
---------
Co-authored-by: Kathleen Tuite <ktuite@getodk.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test for SSLLabs implodes if a Common Name is not set for the cert served for incorrect domains.
See: https://www.ssllabs.com/ssltest/analyze.html?d=production.getodk.cloud
This is a test for the change made in #1366
What has been done to verify that this works as intended?
A new test! And ssllabs test compliance has been confirmed manually.
Why is this the best possible solution? Were any other approaches considered?
There isn't any obvious way to integrate with ssllabs, as its closed-source, and integrating with their API would (1) add a dependency on their live service, and (2) require deploying central publicly before tests can be run.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No change.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)