Merged
Conversation
Owner
|
Looking into this fix, will give a review shortly |
Owner
|
This appears to work on all the webpages I consider heavy hitters, well done. Merging, thanks for contributing the fix :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed
+ RegionData->Regions[RegionIndex].SrcY * RegionData->SrcPitch
+ RegionData->Regions[RegionIndex].SrcX * RegionData->SrcBpp
because when debugging the RHIUpdateTexture2D in FD3D11DynamicRHI it seemed that when
for (uint32 BlockRow = 0; BlockRow < HeightInBlocks; BlockRow++)
{
FMemory::Memcpy(CopyDst, CopySrc, WidthInBlocks * FormatInfo.BlockBytes);
CopySrc += SourcePitch;
CopyDst += StagingPitch;
}
was running the last loop it's throwing AccessViolation error, so it seemed like the "array index" was shifted by one, so in removing that the code in the PR I think the for loop starts from index 0 or whatever is the equivalent in that case
probably the issue is generated by this commit in Epic repo