Events: Separate Rules by EventBus they're assigned to#6091
Merged
bblommers merged 1 commit intogetmoto:masterfrom Mar 20, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6091 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 765 765
Lines 75347 75379 +32
=======================================
+ Hits 72515 72548 +33
+ Misses 2832 2831 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
This is now part of moto >= 4.1.6.dev3 |
viren-nadkarni
added a commit
to localstack/localstack
that referenced
this pull request
Mar 27, 2023
viren-nadkarni
added a commit
to localstack/localstack
that referenced
this pull request
Mar 27, 2023
viren-nadkarni
added a commit
to localstack/localstack
that referenced
this pull request
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules used to be stored in one huge bucket at top-level, but it makes more sense to keep them at the event-bus level
Fixes #6027
The following Events-methods now support the EventBusName-parameter:
delete_rule(), describe_rule(), disable_rule(), enable_rule(), list_rule_names_by_target(), list_rules(), list_targets_by_rule()