feat(openapi3): SchemaBothFormsExclusive cluster for union-typed schema fields#1177
Closed
reuvenharrison wants to merge 1 commit into
Closed
feat(openapi3): SchemaBothFormsExclusive cluster for union-typed schema fields#1177reuvenharrison wants to merge 1 commit into
reuvenharrison wants to merge 1 commit into
Conversation
…ma fields set both ways Three sites in schema.go where a BoolSchema-typed field has both forms set: - additionalProperties - unevaluatedItems - unevaluatedProperties
fenollp
approved these changes
May 9, 2026
fenollp
left a comment
Collaborator
There was a problem hiding this comment.
Hey there, could you turn all these PRs into a single one? Otherwise there will be a lot of rebasing to be done...
This was referenced May 9, 2026
Closed
Contributor
Author
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
SchemaBothFormsExclusivecluster covering the three schema fields stored asBoolSchema(a union ofHas *boolandSchema *SchemaRef) where both forms are set simultaneously.schema.go:1732*SchemaAdditionalPropertiesBothFormsadditionalPropertiesschema.go:1838*SchemaUnevaluatedItemsBothFormsunevaluatedItemsschema.go:1855*SchemaUnevaluatedPropertiesBothFormsunevaluatedPropertiesThis is a different shape from
MutuallyExclusiveFieldsError(which is for two separate fields): here a single union-typed field has both forms populated. The cluster carriesField stringso callers know which property fired without parsing the message.Backward compat
Every converted site preserves its original
Error()string byte-for-byte.Tests
TestValidationError_SchemaBothFormsLeavescovers all three sites end-to-end.