feat(openapi3): ForbiddenFieldError cluster for set-but-not-allowed fields#1172
Closed
reuvenharrison wants to merge 1 commit into
Closed
feat(openapi3): ForbiddenFieldError cluster for set-but-not-allowed fields#1172reuvenharrison wants to merge 1 commit into
reuvenharrison wants to merge 1 commit into
Conversation
…ields Converts four 'field MUST NOT be set in this context' sites: - header.name (given by the headers map key) - header.in (implicitly 'header') - OAuth flow authorizationUrl (wrong flow type) - OAuth flow tokenUrl (wrong flow type)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
ForbiddenFieldErrorcluster covering four sites where the spec forbids a field in a specific context.header.go:57*HeaderNameForbiddennameheader.go:60*HeaderInForbiddeninsecurity_scheme.go:407*OAuthFlowAuthorizationURLForbiddenauthorizationUrlsecurity_scheme.go:420*OAuthFlowTokenURLForbiddentokenUrlBackward compat
Every converted site preserves its original
Error()string byte-for-byte.Tests
TestValidationError_ForbiddenFieldLeavescovers the two header sites end-to-end. The two OAuth flow sites fire through the same constructor pattern and are exercised indirectly through document round-trip validation.