feat(openapi3): MutuallyExclusiveFieldsError cluster for forbidden field pairs#1171
Closed
reuvenharrison wants to merge 2 commits into
Closed
feat(openapi3): MutuallyExclusiveFieldsError cluster for forbidden field pairs#1171reuvenharrison wants to merge 2 commits into
reuvenharrison wants to merge 2 commits into
Conversation
…eld pairs Converts four mutual-exclusion sites: - example.value vs externalValue - mediaType.example vs examples - license.url vs identifier - link.operationId vs operationRef
…ExclusiveFieldsError
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
MutuallyExclusiveFieldsErrorcluster covering five sites where the spec forbids two fields being set together.example.go:78*ExampleValueExternalValueExclusivevalue/externalValuemedia_type.go:128*MediaTypeExampleExamplesExclusiveexample/exampleslicense.go:79*LicenseURLIdentifierExclusiveurl/identifierlink.go:91*LinkOperationIDRefExclusiveoperationId/operationRefschema.go:1415*SchemaReadOnlyWriteOnlyExclusivereadOnly/writeOnlyBackward compat
Every converted site preserves its original
Error()string byte-for-byte. Thelink.OperationID/OperationRefsite keeps its dynamic%qformatting via the leaf constructor.Tests
TestValidationError_MutuallyExclusiveFieldsLeavescovers four of the five sites end-to-end (the fifth,media_type, fires through the same constructor and is exercised indirectly through document round-trips).