Skip to content

Feat: add lud16 to get_info response#1128

Merged
rolznz merged 1 commit intofeat/nwafrom
feat/nwa-lud16
Feb 26, 2025
Merged

Feat: add lud16 to get_info response#1128
rolznz merged 1 commit intofeat/nwafrom
feat/nwa-lud16

Conversation

@rolznz
Copy link
Copy Markdown
Contributor

@rolznz rolznz commented Feb 25, 2025

(Almost all of it is just updating tests, see get_info_controller.go)

@rolznz rolznz merged commit 81e4139 into feat/nwa Feb 26, 2025
11 checks passed
@rolznz rolznz deleted the feat/nwa-lud16 branch February 26, 2025 06:41
rolznz added a commit that referenced this pull request Feb 27, 2025
* feat: nwc create_connection command (WIP)

* feat: allow creating superuser apps from the ui

* fix: pass methods rather than scopes in create_connection method

* chore: add extra tests

* fix: use browser router in http mode

* fix: update links to not use hash router

* fix: add redirect from hash router url

* fix: return nostrWalletConnectUrl in nwc connection success event and message

* feat: publish nwa event

* chore: use nwc info event instead of nwa event

* feat: create custom alby go detail page

* chore: allow creating/editing apps with the same name

* fix: convert budget from msats to sats (#1111)

* chore: address NWA feedback

* chore: address feedback

- adjust button copy
- make create_connection methods consistent with http deeplink flow
- remove unused constant
- add empty string check before adding lud16 tag
- fix test

* feat: add support for notification_types in create_connection method

* fix: shorter button copy

* fix: do not include lud16 tag in published info event

* Feat: add lud16 to get_info response (#1128)

feat: add lud16 to get_info response

* chore: minor alby go screen improvements

* fix: incorrect unlock password error message to create app with superuser access

* chore: minor ui improvements on alby go detail page

* chore: avoid duplicate app names by adding a suffix

* chore: move scopes check to apps service, add new tests, DRY controller test setup

* fix: scopes component full access scopes and isolated scope group check

* fix: use supported capabilities for Alby Go

* fix: return correct app name

* chore: address minor comments

---------

Co-authored-by: im-adithya <imadithyavardhan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant