cmake: fix tarball builds and generated path handling#303
cmake: fix tarball builds and generated path handling#303spe-ciellt merged 1 commit intogerbv:developfrom
Conversation
d76e8c1 to
5c3e522
Compare
5c3e522 to
6121699
Compare
6121699 to
758321e
Compare
Signed-off-by: Rui Chen <rui@chenrui.dev>
758321e to
13e73c2
Compare
|
Thank you for this pull request, looks relevant. I will double check this and merge if OK in a couple of days. |
|
Reviewed for security and consistency. Looks good overall — no security concerns, sensible packaging fixes. A few notes: GetGitVersion.cmake — The config/CMakeLists.txt — Changing locale/CMakeLists.txt — Using man/CMakeLists.txt — Removing the src/CMakeLists.txt — Replacing CMakeLists.txt — No issues found. LGTM. |
|
Additional note: the These are POSIX/XSI math constants (not C standard), and the project sets
|
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
Thanks for the merge, also log a pr to add macos CI, #327. |
Fix CMake tarball builds used by downstream packaging.
PROJECT_VERSIONwhen Git metadata is unavailableRef: Homebrew/homebrew-core#269931