fwiw, even if eslint chokes on my style (and the error makes no sense to me):

/home/runner/work/MapStore2/MapStore2/web/client/utils/WMTSUtils.js
Error:   110:16  error  Unnecessary 'else' after 'return'  no-else-return

i've tested the resulting war locally built by backporting those 3 commits to ms2-geor, and that fixes the two distinct WMTS printing issues i was seeing. There are probably more here and there, but from my side that's already an improvement.

@landryb thank you for your contribution. A reviewer has been assigned, we will review this PR as soon as possible. I've just noticed few failing tests that maybe you want to check in the meantime.

I've just noticed few failing tests that maybe you want to check in the meantime.

fwiw that's what i had put in my previous comment, i have no idea why eslint chokes on this else. Or maybe the else should just be dropped completely, but those coding rules feel a bit strange.

This is the detail of the rule:

https://eslint.org/docs/rules/no-else-return

If the "if" blocks contains a return, the else is an unnecessary block.
It took a little to me too to understand. ;)

Example:

if (condition) {
  return x;
} else {
  // do y
}
return z;

is the same of

if (condition) {
  return x;
}
// do y
return z;

So the else is unnecessary and it may complicate the code reading.

@ElenaGallo, could you please test this on DEV ? Thank you

You can test you can now print layers from these two WMTS services
https://tiles.craig.fr/ortho/service
https://wmts.craig.fr/ortho/service
Another server to test is the following: (you need to customize localConfig.json --> proxy --> useCors to add "https://wxs.ign.fr" to the list. )
https://wxs.ign.fr/essentiels/geoportail/wmts?SERVICE=WMTS&REQUEST=GetCapabilities

Test passed, @offtherailz please backport to stable branch.

thanks @offtherailz for the merge !

to fully test the default value for requestEncoding one should test printing layers coming from https://wxs.ign.fr/essentiels/geoportail/wmts?SERVICE=WMTS&REQUEST=GetCapabilities which isnt mapproxy (and is also extensively used in ms2-georchestra instances)

tiles & wmts.craig.fr are aliases for our mapproxy service.

Thank you @landryb for the hint, i improved my test description and verified that it worked