make endianess configurable for the elevation layer#6579
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Feb 26, 2021
Merged
make endianess configurable for the elevation layer#6579offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
offtherailz
approved these changes
Feb 26, 2021
offtherailz
pushed a commit
to offtherailz/MapStore2
that referenced
this pull request
Mar 1, 2021
offtherailz
added a commit
that referenced
this pull request
Mar 4, 2021
agpenton
pushed a commit
to agpenton/MapStore2
that referenced
this pull request
Jul 8, 2021
agpenton
pushed a commit
to agpenton/MapStore2
that referenced
this pull request
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf georchestra/mapstore2-georchestra#331 for the rationale
Description
the idea is to be able to configure the endianess of the BIL data sent by the WMS server - this way the client code knows how to decode it.
I've successfully tested this with a DEM layer coming from mapserver, which seems to encode BIL as little-endian, with no way to configure it. Should be easily testable with a geoserver layer configured to serve BIL as little endian too. I've also tested it with a geoserver layer in BE mode, still works.
tested both with
MousePositionand the cesium 3d view, but more testing is welcome !Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
georchestra/mapstore2-georchestra#331
What is the new behavior?
Ability to use a DEM layer provided as little-endian BIL.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
No breaking change, as if not defined
littleendiandefaults tofalse, eg the current behaviour.Other useful information